From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTP id A247C487AB
for <ffmpegdev@gitmailbox.com>; Sun, 17 Dec 2023 22:51:40 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6C80968D142;
Mon, 18 Dec 2023 00:51:37 +0200 (EET)
Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net
[217.70.183.199])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B4FC268CF7A
for <ffmpeg-devel@ffmpeg.org>; Mon, 18 Dec 2023 00:51:31 +0200 (EET)
Received: by mail.gandi.net (Postfix) with ESMTPSA id D5BA9FF803
for <ffmpeg-devel@ffmpeg.org>; Sun, 17 Dec 2023 22:51:30 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc;
s=gm1; t=1702853491;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:mime-version:mime-version:content-type:content-type:
in-reply-to:in-reply-to:references:references;
bh=jFISlmW3BSqoGNMYvrMXtPTQyBbqqjQGDFo/3feO8a8=;
b=JYx8MEvtYX2iSicQ+ypjUmHRH2vxRxyLltdI0OQdo2xDMKm7dClu/c2G61DqkzKcnn5l39
RKAvvI852zTjAsDrahALzKpw27zD8fbP/oAq0z+4OpRk9Lf35uck8AchJq54ibaMDyCv8U
WmZrmtw5LFCYSKOFjJs0rUKzS2A2/bB93BWlN+1v3WtJGZi5OJ8iHhYdFUE2JI0OH2Z5BZ
4rx2AXSwYtKbvrG6LtDmP0F3RzBFWoh4hz/oa37luDP0l9knMnbYZyVbWvOOuwTeSsu8JQ
AHO3tKBkTkNHrLEcvqYZMRQ8YRfVwnvtklvHbRP3Rq/EFw/pe8hTFGjIiNrwCg==
Date: Sun, 17 Dec 2023 23:51:30 +0100
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <20231217225130.GV6420@pb2>
References: <20231216081322.53623-1-thilo.borgmann@mail.de>
<20231216081322.53623-2-thilo.borgmann@mail.de>
MIME-Version: 1.0
In-Reply-To: <20231216081322.53623-2-thilo.borgmann@mail.de>
X-GND-Sasl: michael@niedermayer.cc
Subject: Re: [FFmpeg-devel] [PATCH v3 1/2] avfilter: Add fsync filter
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: multipart/mixed; boundary="===============1091037033404736433=="
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20231217225130.GV6420@pb2/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
--===============1091037033404736433==
Content-Type: multipart/signed; micalg=pgp-sha256;
protocol="application/pgp-signature"; boundary="QILrdhYozogw5Vly"
Content-Disposition: inline
--QILrdhYozogw5Vly
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sat, Dec 16, 2023 at 09:13:21AM +0100, Thilo Borgmann via ffmpeg-devel w=
rote:
[...]
> +// get number of bytes from cur to '\0'
> +static int buf_get_zero(FsyncContext *ctx)
maybe doxygen syntax would make sense for comments descrining functions
its not public api but still maybe
> +{
> + return av_strnlen(ctx->cur, ctx->end - ctx->cur);
> +}
> +
[...]
> + if (s->last_frame) {
> + ret =3D av_sscanf(s->cur, "%"PRId64" %"PRId64" %d/%d", &s->ptsi,=
&s->pts, &s->tb_num, &s->tb_den);
> + if (ret !=3D 4) {
> + av_log(ctx, AV_LOG_ERROR, "Unexpected format found (%i / 4).=
\n", ret);
> + ff_outlink_set_status(outlink, AVERROR_INVALIDDATA, AV_NOPTS=
_VALUE);
> + return AVERROR_INVALIDDATA;
> + }
> +
> + av_log(ctx, AV_LOG_DEBUG, "frame %lli ", s->last_frame->pts);
warning: format =E2=80=98%lli=E2=80=99 expects argument of type =E2=80=98lo=
ng long int=E2=80=99, but argument 4 has type =E2=80=98int64_t {aka long in=
t}=E2=80=99 [-Wformat=3D]
"%"PRIi64 / "%"PRId64 / "%"PRIu64 / "%"PRIx64
thx
[...]
--=20
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Never trust a computer, one day, it may think you are the virus. -- Compn
--QILrdhYozogw5Vly
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZX97bgAKCRBhHseHBAsP
qx2qAKCbLRO+Voj8w6GygXxv3OPr7VqIxgCghspwNJmx+M/h5n7oZMnPIYyJ6bI=
=vdAD
-----END PGP SIGNATURE-----
--QILrdhYozogw5Vly--
--===============1091037033404736433==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
--===============1091037033404736433==--