From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 843B248738 for ; Sat, 16 Dec 2023 12:16:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 12F0268D0B3; Sat, 16 Dec 2023 14:16:29 +0200 (EET) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0539968D025 for ; Sat, 16 Dec 2023 14:16:21 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 2E895C0003 for ; Sat, 16 Dec 2023 12:16:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1702728981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:in-reply-to:in-reply-to:references:references; bh=UHl+1XxYXUjVhCLuSoxmMsMJJTKPqZ+J4CjtLGusVzM=; b=SZ8FuzciW7pT+zTL17gWBnvHnSon5LlMjKN8dLRl4CY0Ien5ekY8b8qN7qAQaJJSe6W60/ QQT+qSTeko1hxqnL3BWURocdoRsMPljkYXii15nub4zsI6rspC/P80mLpsNGS0228uxsqu UQmjhbu2uGqxHKbq61idSIXFLGUEs+h0iiVKKT9+rRuXs5cLPpfQYeVewhdxPFFToh2jdn G7dwPg3W8P3AQJmZCqiqTduk+g6x22Z4Hm+bcFEAnysu+VaprK+npdiuuPfnK7LEBJgKPz jNNjP3jS+n7dmRdibpu7K7DVLOOEWA02aseo3OVDYe0wFIPFtXbJLIqCMn5TOw== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Sat, 16 Dec 2023 13:16:17 +0100 Message-Id: <20231216121619.19436-2-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20231216121619.19436-1-michael@niedermayer.cc> References: <20231216121619.19436-1-michael@niedermayer.cc> X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 2/4] avcodec/cbs_vp8: Do not use assert to check for end X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Fixes: abort() Fixes: 64232/clusterfuzz-testcase-minimized-ffmpeg_BSF_TRACE_HEADERS_fuzzer-5417957987319808 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/cbs_vp8.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/cbs_vp8.c b/libavcodec/cbs_vp8.c index 01d4b9cefef..b76cde98517 100644 --- a/libavcodec/cbs_vp8.c +++ b/libavcodec/cbs_vp8.c @@ -329,7 +329,9 @@ static int cbs_vp8_read_unit(CodedBitstreamContext *ctx, pos = get_bits_count(&gbc); pos /= 8; - av_assert0(pos <= unit->data_size); + + if (pos > unit->data_size) + return AVERROR_INVALIDDATA; frame->data_ref = av_buffer_ref(unit->data_ref); if (!frame->data_ref) -- 2.17.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".