From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D7BC2486A9 for ; Thu, 14 Dec 2023 03:09:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EA54168D197; Thu, 14 Dec 2023 05:09:55 +0200 (EET) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 54B8168CFFA for ; Thu, 14 Dec 2023 05:09:50 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id A73F81C0004 for ; Thu, 14 Dec 2023 03:09:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1702523389; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cl9pyyTSum0HiHC1Bt2+MCZ4DM4YCW+UnEEF0KPbETE=; b=f4kbA16AOxyk11W0/muqj3Dsaz3YispxPrjtWz92n1GrS99kxM+iHuiRpmE7EtyVQeO92E GEgBlhhzFYMBhRRbOyRwMqOwkNeBSiR56wGohcUUWgAW86joiT/5rukw8d/Hm+RhXGgCJc TCKjIqlInnv3q7KzJE9mTgJQ5qk1UgmQK1Zmj4E83Pt14HmEUvF3HEw3P452WBSWkKD+NO qcJPhUmQQxJ4y0pNQRa94vstYWvIe0APmOHCI9tNXRQBqjSMwrz2UVSVT+XGmMUy8dnoUA sd/nPg67z7I6w+3TzmtLwb7HfzmtNowCIdmRupjK643Vuq8gW1EyT9Pnojzhtg== Date: Thu, 14 Dec 2023 04:09:48 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20231214030948.GH6420@pb2> References: <20231213131536.10242-1-ffmpeg@haasn.xyz> <20231213131536.10242-4-ffmpeg@haasn.xyz> MIME-Version: 1.0 In-Reply-To: <20231213131536.10242-4-ffmpeg@haasn.xyz> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH v2 03/15] avfilter: add negotiation API for color space/range X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6270934270069512518==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6270934270069512518== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LZFKeWUZP29EKQNE" Content-Disposition: inline --LZFKeWUZP29EKQNE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 13, 2023 at 02:12:00PM +0100, Niklas Haas wrote: > From: Niklas Haas >=20 > Motivated by YUVJ removal. This change will allow full negotiation > between color ranges and matrices as needed. By default, all ranges and > matrices are marked as supported. >=20 > Because grayscale formats are currently handled very inconsistently (and > in particular, assumed as forced full-range by swscale), we exclude them > from negotiation altogether for the time being, to get this API merged. >=20 > After filter negotiation is available, we can relax the > grayscale-is-forced-jpeg restriction again, when it will be more > feasible to do so without breaking a million test cases. >=20 > Note that this commit updates one FATE test as a consequence of the > sanity fallback for non-YUV formats. In particular, the test case now > writes rgb24(pc, gbr/unspecified/unspecified) to the matroska file, > instead of rgb24(unspecified/unspecified/unspecified) as before. > --- > doc/APIchanges | 3 + > libavfilter/avfilter.c | 17 +++- > libavfilter/avfilter.h | 28 ++++++ > libavfilter/avfiltergraph.c | 173 +++++++++++++++++++++++++++++++++++- > libavfilter/formats.c | 122 ++++++++++++++++++++++++- > libavfilter/formats.h | 54 +++++++++++ > libavfilter/internal.h | 6 ++ > libavfilter/vaapi_vpp.c | 4 + > libavfilter/video.c | 2 + > tests/ref/fate/shortest-sub | 4 +- > 10 files changed, 404 insertions(+), 9 deletions(-) segfaults =2E/ffmpeg -f lavfi -i "amovie=3Dfate-suite/wavpack/num_channels/eva_2.22_6= =2E1_16bit-partial.wv,asplit=3D3[out1][a][b]; [a]showwaves=3Ds=3D340x240,pa= d=3Diw:ih*2[waves]; [b]showspectrum=3Ds=3D340x240[spectrum]; [waves][spectr= um] overlay=3D0:h [out0]" -t 0.1 -qscale 2 -bitexact /tmp/file-waves.avi Thread 1 "ffmpeg_g" received signal SIGSEGV, Segmentation fault. 0x00005555557a7c07 in query_formats () (gdb) bt #0 0x00005555557a7c07 in query_formats () #1 0x00005555557a84d5 in avfilter_graph_config () #2 0x000055555569ac0a in lavfi_read_header () #3 0x0000555555a7bd61 in avformat_open_input () #4 0x000055555574cb43 in ifile_open () #5 0x0000555555763c49 in open_files.isra () #6 0x0000555555765327 in ffmpeg_parse_options () #7 0x00005555557442b4 in main () (i can provide better backtrace if you cannot reproduce ...) thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I have often repented speaking, but never of holding my tongue. -- Xenocrates --LZFKeWUZP29EKQNE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZXpx+QAKCRBhHseHBAsP q6DeAJ48iDbrmUjzzECzXZzVEX0zY1ZwPQCgmUgjsTfu96tvCCt+Nm81/qcc0MI= =KrVW -----END PGP SIGNATURE----- --LZFKeWUZP29EKQNE-- --===============6270934270069512518== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6270934270069512518==--