On Wed, Dec 13, 2023 at 02:12:00PM +0100, Niklas Haas wrote: > From: Niklas Haas > > Motivated by YUVJ removal. This change will allow full negotiation > between color ranges and matrices as needed. By default, all ranges and > matrices are marked as supported. > > Because grayscale formats are currently handled very inconsistently (and > in particular, assumed as forced full-range by swscale), we exclude them > from negotiation altogether for the time being, to get this API merged. > > After filter negotiation is available, we can relax the > grayscale-is-forced-jpeg restriction again, when it will be more > feasible to do so without breaking a million test cases. > > Note that this commit updates one FATE test as a consequence of the > sanity fallback for non-YUV formats. In particular, the test case now > writes rgb24(pc, gbr/unspecified/unspecified) to the matroska file, > instead of rgb24(unspecified/unspecified/unspecified) as before. > --- > doc/APIchanges | 3 + > libavfilter/avfilter.c | 17 +++- > libavfilter/avfilter.h | 28 ++++++ > libavfilter/avfiltergraph.c | 173 +++++++++++++++++++++++++++++++++++- > libavfilter/formats.c | 122 ++++++++++++++++++++++++- > libavfilter/formats.h | 54 +++++++++++ > libavfilter/internal.h | 6 ++ > libavfilter/vaapi_vpp.c | 4 + > libavfilter/video.c | 2 + > tests/ref/fate/shortest-sub | 4 +- > 10 files changed, 404 insertions(+), 9 deletions(-) segfaults ./ffmpeg -f lavfi -i "amovie=fate-suite/wavpack/num_channels/eva_2.22_6.1_16bit-partial.wv,asplit=3[out1][a][b]; [a]showwaves=s=340x240,pad=iw:ih*2[waves]; [b]showspectrum=s=340x240[spectrum]; [waves][spectrum] overlay=0:h [out0]" -t 0.1 -qscale 2 -bitexact /tmp/file-waves.avi Thread 1 "ffmpeg_g" received signal SIGSEGV, Segmentation fault. 0x00005555557a7c07 in query_formats () (gdb) bt #0 0x00005555557a7c07 in query_formats () #1 0x00005555557a84d5 in avfilter_graph_config () #2 0x000055555569ac0a in lavfi_read_header () #3 0x0000555555a7bd61 in avformat_open_input () #4 0x000055555574cb43 in ifile_open () #5 0x0000555555763c49 in open_files.isra () #6 0x0000555555765327 in ffmpeg_parse_options () #7 0x00005555557442b4 in main () (i can provide better backtrace if you cannot reproduce ...) thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I have often repented speaking, but never of holding my tongue. -- Xenocrates