From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2ECD6481EE for ; Tue, 12 Dec 2023 23:17:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2086B68D0E0; Wed, 13 Dec 2023 01:17:04 +0200 (EET) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A3CDB68CD4B for ; Wed, 13 Dec 2023 01:16:57 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 072C560003 for ; Tue, 12 Dec 2023 23:16:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1702423017; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kmIHzBgHYtLAk7+osUXgyUBKDrsRhYmbJLjuShk7INw=; b=WCj6ta09t9AYmfdmWn++Gx/axMbzok/DfJzGyf8H5v1p4mCMGspqfWM/FL5izz3dlP+Vjf woXTx6CLZKTlu50YuMfsrVEdU8NfcvLlkTTCDdCOphczBwhjk4dSHkFMYdsClmO5SRGiqS UEXaBIRbfTPQ3VIFCvllkNBL0BDLXTP3RMQuQ2Vc9vmYwjcgUNeIdZdrJXp/CTLBCQZHqI UbyyyYW/K94vCIPDk7vF03uIT8KQYhNCXtNBihQHjOWT0SkRFwUOb0eNfN9z5pD+li6Kbt YwqciIFWEeeDFwIsPZLie+eO/1zz2tHGoZc8j5fzzjkyMQg8eO8zeU3GK1KWMw== Date: Wed, 13 Dec 2023 00:16:56 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20231212231656.GE6420@pb2> References: <20231211190908.1882569-1-u@pkh.me> <20231211190908.1882569-4-u@pkh.me> <20231212231336.GD6420@pb2> MIME-Version: 1.0 In-Reply-To: <20231212231336.GD6420@pb2> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 3/5] avcodec/proresenc_kostya: do not write into alpha reserved bitfields X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2518210592568882041==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2518210592568882041== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="G6nVm6DDWH/FONJq" Content-Disposition: inline --G6nVm6DDWH/FONJq Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 13, 2023 at 12:13:36AM +0100, Michael Niedermayer wrote: > On Mon, Dec 11, 2023 at 08:06:53PM +0100, Cl=E9ment B=BDsch wrote: > > This byte represents 4 reserved bits followed by 4 alpha_channel_type b= its. > >=20 > > alpha_channel_type currently has 3 differents defined values: 0 (no > > alpha), 1 (8b alpha), and 2 (16b alpha), all the other values are > > reserved. This part is correctly written (alpha_bits>>3 does the correct > > thing), but the 4 initial bits are reserved. > > --- > > libavcodec/proresenc_kostya.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > This breaks fate (not just changing the value but actually breaking it) This is about the next patch "avcodec/proresenc_anatoliy: do not write into= alpha reserved bitfields" I used a too short search string for the subject i replied to ... (so issue is real but its the next patch) >=20 > --- ./tests/ref/vsynth/vsynth1-prores_444_int 2023-12-02 00:46:44.2770428= 42 +0100 > +++ tests/data/fate/vsynth1-prores_444_int 2023-12-13 00:11:22.144115839 = +0100 > @@ -1,4 +1,2 @@ > -1d5e484fa8ca08781ef2ed8428963d12 *tests/data/fate/vsynth1-prores_444_int= =2Emov > +d75a2ba07d0642340d040edab6cbb3bb *tests/data/fate/vsynth1-prores_444_int= =2Emov > 9940947 tests/data/fate/vsynth1-prores_444_int.mov > -732ceeb6887524e0aee98762fe50578b *tests/data/fate/vsynth1-prores_444_int= =2Eout.rawvideo > -stddev: 2.83 PSNR: 39.08 MAXDIFF: 45 bytes: 7603200/ 7603200 [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Some people wanted to paint the bikeshed green, some blue and some pink. People argued and fought, when they finally agreed, only rust was left. --G6nVm6DDWH/FONJq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZXjp6AAKCRBhHseHBAsP q0x5AJ9GkiC5jwmFOTzHsMzdMJLqOZ1iawCgmwgi8ImpOE9SDVEpMkt9GLitAQA= =XMgc -----END PGP SIGNATURE----- --G6nVm6DDWH/FONJq-- --===============2518210592568882041== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2518210592568882041==--