From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 783EB462D3 for ; Tue, 12 Dec 2023 23:13:46 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C9A8968D020; Wed, 13 Dec 2023 01:13:44 +0200 (EET) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BEE6668CF2C for ; Wed, 13 Dec 2023 01:13:37 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id D3C051BF203 for ; Tue, 12 Dec 2023 23:13:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1702422817; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ze4YhQ767CezgyAd0R+mxCpWQ/BQ9nvEdm/cvX/jG4U=; b=eVWbpI7QZ83r2V+/UV/9kNa/kdjLxXZCs4eKMsRo841A8fbSzUZFuBmDQ084SG3B26UVQl UB7adHUQyl8ncwLo4/feOy4tOTrWTvvER4FrJBmVfpA63JZbzT9+eFNzAAmEHwP/kTMJCs bdZqma8xqzyNuvOp4RtEYIr9wyp4z9npS114aqGsGW1uQebKHCuzGQjQ2xNMhEZ53S986m GPRMH1p/VDUuoVJTPVts9M02DkdCL8JRTg6F+sz3306oPUiBPfLCk7ewswvN+NZdbGaD6R OZWialU7+NHmPP+1jViYuqDL/5a5PS2aeoBDnBit7mTr3jegTwbyHToaK09AwA== Date: Wed, 13 Dec 2023 00:13:36 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20231212231336.GD6420@pb2> References: <20231211190908.1882569-1-u@pkh.me> <20231211190908.1882569-4-u@pkh.me> MIME-Version: 1.0 In-Reply-To: <20231211190908.1882569-4-u@pkh.me> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 3/5] avcodec/proresenc_kostya: do not write into alpha reserved bitfields X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7861523132408269464==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7861523132408269464== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XvKFcGCOAo53UbWW" Content-Disposition: inline --XvKFcGCOAo53UbWW Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 11, 2023 at 08:06:53PM +0100, Cl=E9ment B=BDsch wrote: > This byte represents 4 reserved bits followed by 4 alpha_channel_type bit= s. >=20 > alpha_channel_type currently has 3 differents defined values: 0 (no > alpha), 1 (8b alpha), and 2 (16b alpha), all the other values are > reserved. This part is correctly written (alpha_bits>>3 does the correct > thing), but the 4 initial bits are reserved. > --- > libavcodec/proresenc_kostya.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This breaks fate (not just changing the value but actually breaking it) --- ./tests/ref/vsynth/vsynth1-prores_444_int 2023-12-02 00:46:44.277042842= +0100 +++ tests/data/fate/vsynth1-prores_444_int 2023-12-13 00:11:22.144115839 +0= 100 @@ -1,4 +1,2 @@ -1d5e484fa8ca08781ef2ed8428963d12 *tests/data/fate/vsynth1-prores_444_int.m= ov +d75a2ba07d0642340d040edab6cbb3bb *tests/data/fate/vsynth1-prores_444_int.m= ov 9940947 tests/data/fate/vsynth1-prores_444_int.mov -732ceeb6887524e0aee98762fe50578b *tests/data/fate/vsynth1-prores_444_int.o= ut.rawvideo -stddev: 2.83 PSNR: 39.08 MAXDIFF: 45 bytes: 7603200/ 7603200 thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The bravest are surely those who have the clearest vision of what is before them, glory and danger alike, and yet notwithstanding go out to meet it. -- Thucydides --XvKFcGCOAo53UbWW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZXjpGAAKCRBhHseHBAsP qwLrAJ9roxaMj4wqIELXpCLMmwYk0vY7owCgjQwdTpm+dwz27poeCIC61CtTLGQ= =e0tk -----END PGP SIGNATURE----- --XvKFcGCOAo53UbWW-- --===============7861523132408269464== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7861523132408269464==--