Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Clément Bœsch" <u@pkh.me>
To: ffmpeg-devel@ffmpeg.org
Cc: "Clément Bœsch" <u@pkh.me>
Subject: [FFmpeg-devel] [PATCH 07/35] avcodec/proresenc_anatoliy: move DC codebook LUT to shared proresdata
Date: Mon, 11 Dec 2023 02:35:08 +0100
Message-ID: <20231211014429.1841681-8-u@pkh.me> (raw)
In-Reply-To: <20231211014429.1841681-1-u@pkh.me>

This is going to be shared with proresenc_kostya in the upcoming commit.
---
 libavcodec/proresdata.c         | 2 ++
 libavcodec/proresdata.h         | 1 +
 libavcodec/proresenc_anatoliy.c | 3 +--
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/libavcodec/proresdata.c b/libavcodec/proresdata.c
index 12ee43bddd..866839c8d1 100644
--- a/libavcodec/proresdata.c
+++ b/libavcodec/proresdata.c
@@ -44,6 +44,8 @@ const uint8_t ff_prores_interlaced_scan[64] = {
     46, 39, 47, 54, 61, 62, 55, 63
 };
 
+const uint8_t ff_prores_dc_codebook[7] = { 0x04, 0x28, 0x28, 0x4D, 0x4D, 0x70, 0x70 };
+
 const uint8_t ff_prores_run_to_cb[16] = { 0x06, 0x06, 0x05, 0x05, 0x04, 0x29,
         0x29, 0x29, 0x29, 0x28, 0x28, 0x28, 0x28, 0x28, 0x28, 0x4C };
 
diff --git a/libavcodec/proresdata.h b/libavcodec/proresdata.h
index 4d16992892..e24472d844 100644
--- a/libavcodec/proresdata.h
+++ b/libavcodec/proresdata.h
@@ -29,6 +29,7 @@
 
 extern const uint8_t ff_prores_progressive_scan[64];
 extern const uint8_t ff_prores_interlaced_scan[64];
+extern const uint8_t ff_prores_dc_codebook[7];
 extern const uint8_t ff_prores_run_to_cb[16];
 extern const uint8_t ff_prores_lev_to_cb[10];
 
diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c
index c6f49be9b8..d6f5cefc16 100644
--- a/libavcodec/proresenc_anatoliy.c
+++ b/libavcodec/proresenc_anatoliy.c
@@ -266,7 +266,6 @@ static av_always_inline int get_level(int val)
     return (val ^ sign) - sign;
 }
 
-static const uint8_t dc_codebook[7] = { 0x04, 0x28, 0x28, 0x4D, 0x4D, 0x70, 0x70};
 
 static void encode_dc_coeffs(PutBitContext *pb, int16_t *in,
         int blocks_per_slice, int *qmat)
@@ -286,7 +285,7 @@ static void encode_dc_coeffs(PutBitContext *pb, int16_t *in,
         diff_sign = DIFF_SIGN(delta, sign);
         new_code  = TO_GOLOMB2(get_level(delta), diff_sign);
 
-        encode_codeword(pb, new_code, dc_codebook[FFMIN(code, 6)]);
+        encode_codeword(pb, new_code, ff_prores_dc_codebook[FFMIN(code, 6)]);
 
         code      = new_code;
         sign      = delta >> 31;
-- 
2.43.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2023-12-11  1:49 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-11  1:35 [FFmpeg-devel] Initial tickering at unifying ProRes encoder Clément Bœsch
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 01/35] avcodec/proresenc_kostya: remove an unnecessary parenthesis level in MAKE_CODE() macro Clément Bœsch
2023-12-12  6:53   ` Stefano Sabatini
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 02/35] avcodec/proresenc_kostya: remove unused plane factor variables Clément Bœsch
2023-12-12  6:56   ` Stefano Sabatini
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 03/35] avcodec/proresenc_kostya: remove redundant codebook assignments Clément Bœsch
2023-12-12  7:00   ` Stefano Sabatini
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 04/35] avcodec/proresenc_anatoliy: move run/lev to codebook LUT to shared proresdata Clément Bœsch
2023-12-12  7:02   ` Stefano Sabatini
2023-12-12  8:02   ` Stefano Sabatini
2024-01-08 17:06     ` Clément Bœsch
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 05/35] avcodec/proresenc_kostya: remove one LUT indirection for run/level to codebook mapping Clément Bœsch
2023-12-12  8:16   ` Stefano Sabatini
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 06/35] avcodec/proresenc_anatoliy: remove duplicated define Clément Bœsch
2023-12-16 16:32   ` Stefano Sabatini
2023-12-11  1:35 ` Clément Bœsch [this message]
2023-12-16 16:33   ` [FFmpeg-devel] [PATCH 07/35] avcodec/proresenc_anatoliy: move DC codebook LUT to shared proresdata Stefano Sabatini
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 08/35] avcodec/proresenc_kostya: save a few operations in DC encoding Clément Bœsch
2023-12-16 16:54   ` Stefano Sabatini
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 09/35] avcodec/proresenc_kostya: fix chroma quantisation matrix in frame header Clément Bœsch
2023-12-16 17:12   ` Stefano Sabatini
2024-01-06 17:12     ` Clément Bœsch
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 10/35] avcodec/proresenc_kostya: simplify quantization matrix bytestream writing Clément Bœsch
2023-12-17 18:18   ` Stefano Sabatini
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 11/35] avcodec/proresenc_anatoliy: use FRAME_ID defined in proresdata.h Clément Bœsch
2023-12-17 18:19   ` Stefano Sabatini
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 12/35] avcodec/proresenc_anatoliy: shuffle encode_codeword() code to match Kostya encoder Clément Bœsch
2023-12-18  0:07   ` Stefano Sabatini
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 13/35] avcodec/proresenc_anatoliy: rework encode_codeword() prototype Clément Bœsch
2023-12-18  0:09   ` Stefano Sabatini
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 14/35] avcodec/proresenc_anatoliy: inline QSCALE() Clément Bœsch
2023-12-18  0:13   ` Stefano Sabatini
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 15/35] avcodec/proresenc_anatoliy: rename new_code/code to code/codebook Clément Bœsch
2023-12-18  0:18   ` Stefano Sabatini
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 16/35] avcodec/proresenc_anatoliy: execute codebook FFMIN() at assignment Clément Bœsch
2023-12-18  0:24   ` Stefano Sabatini
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 17/35] avcodec/proresenc_anatoliy: reduce DC encoding function prototype differences with Kostya encoder Clément Bœsch
2023-12-18  0:26   ` Stefano Sabatini
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 18/35] avcodec/proresenc_anatoliy: directly work with blocks in encode_dcs() Clément Bœsch
2023-12-18  0:30   ` Stefano Sabatini
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 19/35] avcodec/proresenc_anatoliy: import GET_SIGN() macro from Kostya encoder and use it Clément Bœsch
2023-12-18  0:30   ` Stefano Sabatini
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 20/35] avcodec/proresenc_anatoliy: compute sign only once Clément Bœsch
2023-12-18  0:37   ` Stefano Sabatini
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 21/35] avcodec/proresenc_anatoliy: rename new_dc to dc Clément Bœsch
2023-12-18  0:38   ` Stefano Sabatini
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 22/35] avcodec/proresenc_anatoliy: remove IS_NEGATIVE() macro Clément Bœsch
2023-12-18 22:29   ` Stefano Sabatini
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 23/35] avcodec/proresenc_kostya: add Anatoliy copyright Clément Bœsch
2023-12-18 22:30   ` Stefano Sabatini
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 24/35] avcodec/proresenc_anatoliy: rename TO_GOLOMB() to MAKE_CODE() Clément Bœsch
2023-12-18 22:32   ` Stefano Sabatini
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 25/35] avcodec/proresenc_anatoliy: shuffle declarations around in encode_dcs() Clément Bœsch
2023-12-18 22:35   ` Stefano Sabatini
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 26/35] avcodec/proresenc_anatoliy: only pass down the first scale to encode_dcs() Clément Bœsch
2023-12-18 22:36   ` Stefano Sabatini
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 27/35] avcodec/proresenc_anatoliy: remove TO_GOLOMB2() Clément Bœsch
2023-12-23 23:43   ` Stefano Sabatini
2024-01-07 23:00     ` Clément Bœsch
2024-01-09 23:08       ` Stefano Sabatini
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 28/35] avcodec/proresenc_anatoliy: cosmetics to make encode_dcs() identical to the one in Kostya encoder Clément Bœsch
2023-12-23 23:46   ` Stefano Sabatini
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 29/35] avcodec/proresenc_anatoliy: replace get_level() with FFABS() Clément Bœsch
2023-12-24 10:25   ` Stefano Sabatini
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 30/35] avcodec/proresenc_anatoliy: rework encode_ac_coeffs() prototype Clément Bœsch
2023-12-24 10:26   ` Stefano Sabatini
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 31/35] avcodec/proresenc_anatoliy: avoid using ff_ prefix in function arguments Clément Bœsch
2023-12-24 10:27   ` Stefano Sabatini
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 32/35] avcodec/proresenc_anatoliy: rework inner loop in encode_acs() Clément Bœsch
2023-12-24 10:36   ` Stefano Sabatini
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 33/35] avcodec/proresenc_anatoliy: execute AC run/level FFMIN() at assignment Clément Bœsch
2023-12-24 10:40   ` Stefano Sabatini
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 34/35] avcodec/proresenc_anatoliy: make a few cosmetics in encode_acs() Clément Bœsch
2023-12-24 10:45   ` Stefano Sabatini
2023-12-11  1:35 ` [FFmpeg-devel] [PATCH 35/35] avcodec/proresenc_kostya: " Clément Bœsch
2023-12-24 10:46   ` Stefano Sabatini
2023-12-11  9:15 ` [FFmpeg-devel] Initial tickering at unifying ProRes encoder Anton Khirnov
2023-12-11  9:36   ` Clément Bœsch
2023-12-24 10:56 ` Stefano Sabatini
2024-01-10 13:22   ` Clément Bœsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231211014429.1841681-8-u@pkh.me \
    --to=u@pkh.me \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git