[FFmpeg-devel] [PATCH] tools/general_assembly: avoid using DateTime->is_between()

[FFmpeg-devel] [PATCH] tools/general_assembly: avoid using DateTime->is_between()

[Anton Khirnov]

It was added relatively recently and is not available everywhere.
---
 tools/general_assembly.pl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/general_assembly.pl b/tools/general_assembly.pl
index aa10384aef..0dafa82e27 100755
--- a/tools/general_assembly.pl
+++ b/tools/general_assembly.pl
@@ -72,7 +72,7 @@ sub get_date_range {
     # date when the regular update rule is first applied
     my $date_first_regular = DateTime->new(year => 2024);
 
-    if ($now->is_between($date_ga_rule, $date_first_regular)) {
+    if ($now > $date_ga_rule && $now < $date_first_regular) {
         return ($date_ga_rule->clone()->set_year($date_ga_rule->year - 3), $date_ga_rule);
     }
 
@@ -123,7 +123,7 @@ foreach my $line (@shortlog) {
 
 foreach my $entry (@extra_members) {
     my $elected = $entry->[2];
-    if ($date->is_between($elected, $elected->clone()->set_year($elected->year + 2))) {
+    if ($date > $elected && $date < $elected->clone()->set_year($elected->year + 2)) {
         $assembly{$entry->[0]} = $entry->[1];
     }
 }
-- 
2.42.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] tools/general_assembly: avoid using DateTime->is_between()

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 500 bytes --]

On Thu, Dec 07, 2023 at 05:49:12PM +0100, Anton Khirnov wrote:
> It was added relatively recently and is not available everywhere.
> ---
>  tools/general_assembly.pl | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

works fine, even on my oldest box

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".