Re: [FFmpeg-devel] [PATCH 2/2] aacdec: fix single-sample delay for SBR streams

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] aacdec: fix single-sample delay for SBR streams
Date: Tue, 5 Dec 2023 02:47:22 +0100
Message-ID: <20231205014722.GW3543730@pb2> (raw)
In-Reply-To: <Nkno0wK--3-9@lynne.ee>

[-- Attachment #1.1: Type: text/plain, Size: 1527 bytes --]

On Mon, Dec 04, 2023 at 08:52:06AM +0100, Lynne wrote:
> Our SBR implementation introduces a single sample of latency into the
> output, which is currently never skipped.
> This delay is separate from any container skip value and always present,
> as it is from an additional part of the decoding process.
> 
> Fixes Trac issue #9667
> 

>  aac.h             |    1 +
>  aacdec_template.c |   23 ++++++++++++++++++-----
>  2 files changed, 19 insertions(+), 5 deletions(-)
> 100f2e0512732bbf24f36e1524e07fb6c3fa0831  0002-aacdec-fix-single-sample-delay-for-SBR-streams.patch
> From 5b9d971b108677d54bc3aac317669007462dbcc9 Mon Sep 17 00:00:00 2001
> From: Lynne <dev@lynne.ee>
> Date: Mon, 30 Oct 2023 05:40:22 +0100
> Subject: [PATCH 2/2] aacdec: fix single-sample delay for SBR streams
> 
> Our SBR implementation introduces a single sample of latency into the
> output, which is currently never skipped.
> This delay is separate from any container skip value and always present,
> as it is from an additional part of the decoding process.
> 
> Fixes Trac issue #9667
> ---
>  libavcodec/aac.h             |  1 +
>  libavcodec/aacdec_template.c | 23 ++++++++++++++++++-----
>  2 files changed, 19 insertions(+), 5 deletions(-)

this affects many fate tests

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Does the universe only have a finite lifespan? No, its going to go on
forever, its just that you wont like living in it. -- Hiranya Peiri

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".