[FFmpeg-devel] [PATCH] avcodec/av1dec: Fix resolving zero divisor

* [FFmpeg-devel] [PATCH] avcodec/av1dec: Fix resolving zero divisor
@ 2023-11-30 12:28 Michael Niedermayer via ffmpeg-devel
  0 siblings, 0 replies; only message in thread
From: Michael Niedermayer via ffmpeg-devel @ 2023-11-30 12:28 UTC (permalink / raw)
  To: FFmpeg development discussions and patches; +Cc: Michael Niedermayer

Fixes: Out of array read
Fixes: global-buffer-overflow-AV1

Found-by: "Leonelli, Matteo" <matteo.leonelli@cispa.de>
Tested-by: "Wang, Fei W" <fei.w.wang@intel.com>
Reviewed-by: "Wang, Fei W" <fei.w.wang@intel.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavcodec/av1dec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c
index 6114cb78e65..4dcde234c6c 100644
--- a/libavcodec/av1dec.c
+++ b/libavcodec/av1dec.c
@@ -177,7 +177,7 @@ static uint8_t get_shear_params_valid(AV1DecContext *s, int idx)
     int16_t alpha, beta, gamma, delta, divf, divs;
     int64_t v, w;
     int32_t *param = &s->cur_frame.gm_params[idx][0];
-    if (param[2] < 0)
+    if (param[2] <= 0)
         return 0;
 
     alpha = av_clip_int16(param[2] - (1 << AV1_WARPEDMODEL_PREC_BITS));
-- 
2.17.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] only message in thread