From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DA57847DB0 for ; Mon, 27 Nov 2023 05:37:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B178568CF2C; Mon, 27 Nov 2023 07:37:40 +0200 (EET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D700E68CB9D for ; Mon, 27 Nov 2023 07:37:33 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701063459; x=1732599459; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=UYFIoz4/M0o0NaNzVd+G96DOvP/xlA9IhFUgPVm2t6Q=; b=Tz6sIR2+qTPGHwatFt279/leQCMInpGveuScaor4iUgdJk8csgAM1lr4 CWmjXJP4YA7240S3d1o+AlbNuiTBQAs5lJF3mf02YONFl58PfKYZ7xI8o xcq4AKefBRlBnqORQuNDmp9vcRP9Ha4NhwfNuvssmkIV87frx/+6J1chO m2cUUcEZrJAvlsS922u1DW5eqkE5z0rwW2aMMB3mMtpfrIr3YFVQCzxFu Nw4HIGBmgcIAfsfV3R5PAmBoNuAHUo6dXAmTQjcxr5R8dQ9gg8J69QkHv r6+uT0DT+66rZ5Nk9S6PpEiYnnqttBQLgYqj4vYNN1eAe4o7CzU+UUs/q w==; X-IronPort-AV: E=McAfee;i="6600,9927,10906"; a="459129858" X-IronPort-AV: E=Sophos;i="6.04,230,1695711600"; d="scan'208";a="459129858" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Nov 2023 21:37:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10906"; a="891624541" X-IronPort-AV: E=Sophos;i="6.04,230,1695711600"; d="scan'208";a="891624541" Received: from xhh-dg264.sh.intel.com ([10.238.2.76]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Nov 2023 21:37:29 -0800 From: "Xiang, Haihao" To: ffmpeg-devel@ffmpeg.org Date: Mon, 27 Nov 2023 13:37:22 +0800 Message-Id: <20231127053722.2420663-1-haihao.xiang@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v2] lavu/hwcontext_qsv: use mfxImplDescription instead of mfxExtendedDeviceId on Linux X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Haihao Xiang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: Haihao Xiang mfxExtendedDeviceId mightn't be supported in certain configurations of oneVPL on Linux, so we can't ensure a property filter for mfxExtendedDeviceId.DeviceID or mfxExtendedDeviceId.VendorID works as expected. This fixed the issue mentioned in [1] [1] http://ffmpeg.org/pipermail/ffmpeg-user/2023-October/056983.html Signed-off-by: Haihao Xiang --- libavutil/hwcontext_qsv.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavutil/hwcontext_qsv.c b/libavutil/hwcontext_qsv.c index 1bfda9e69b..7f4a0fda0f 100644 --- a/libavutil/hwcontext_qsv.c +++ b/libavutil/hwcontext_qsv.c @@ -821,7 +821,7 @@ static int qsv_va_update_config(void *ctx, mfxHDL handle, mfxConfig cfg) impl_value.Type = MFX_VARIANT_TYPE_U16; impl_value.Data.U16 = (attr.value & 0xFFFF); sts = MFXSetConfigFilterProperty(cfg, - (const mfxU8 *)"mfxExtendedDeviceId.DeviceID", impl_value); + (const mfxU8 *)"mfxImplDescription.mfxDeviceDescription.DeviceID", impl_value); if (sts != MFX_ERR_NONE) { av_log(ctx, AV_LOG_ERROR, "Error adding a MFX configuration" "DeviceID property: %d.\n", sts); @@ -893,10 +893,10 @@ static int qsv_new_mfx_loader(void *ctx, goto fail; } - impl_value.Type = MFX_VARIANT_TYPE_U16; - impl_value.Data.U16 = 0x8086; // Intel device only + impl_value.Type = MFX_VARIANT_TYPE_U32; + impl_value.Data.U32 = 0x8086; // Intel device only sts = MFXSetConfigFilterProperty(cfg, - (const mfxU8 *)"mfxExtendedDeviceId.VendorID", impl_value); + (const mfxU8 *)"mfxImplDescription.VendorID", impl_value); if (sts != MFX_ERR_NONE) { av_log(ctx, AV_LOG_ERROR, "Error adding a MFX configuration" "VendorID property: %d.\n", sts); -- 2.34.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".