From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2B18446FCE for ; Fri, 24 Nov 2023 22:56:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 394D068CEF4; Sat, 25 Nov 2023 00:56:35 +0200 (EET) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 32EA268CAA2 for ; Sat, 25 Nov 2023 00:56:29 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 463CA60003 for ; Fri, 24 Nov 2023 22:56:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1700866588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G4jPAPBfbQVlTd+VJWjvTO7RpYhF9si1z4rCBs/PCwQ=; b=NZdRUjEk4rL6AGKhKLnl6IWinPZ3bGcNbiepzVX+ImMI4GWd5eItRlTYqE3KKHgpCSgJFL b35bHqls6roirRnJYRelk/SPUOt2IiF8vguruMlnuWLzf9Dx2og63LTPRvPiLiDBOuKAMW gQzF9GcYlo52sSjWvbIB45T17FzqHhZuw+AyNOCtlj6LHY6anCvipuNljpBAcrpC0t+L34 bVUP5u/2Mia3j8TRh+PgK77dP3+1jil6GDB05vw/wDn8PN+sx5fLSo4B1FrRWFV2Fmhj01 JAoPYth69c9yev8loxMGKan77q17rTzNj9iJCgUq+CTarjn0RWFI1kNHxqkuLw== Date: Fri, 24 Nov 2023 23:56:27 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20231124225627.GI3543730@pb2> References: <20231123191524.11296-2-anton@khirnov.net> <20231123191524.11296-7-anton@khirnov.net> MIME-Version: 1.0 In-Reply-To: <20231123191524.11296-7-anton@khirnov.net> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 05/13] fftools/ffmpeg_filter: move filtering to a separate thread X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1076585733341640781==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1076585733341640781== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="My/g3/QBGFyfc/K1" Content-Disposition: inline --My/g3/QBGFyfc/K1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 23, 2023 at 08:15:00PM +0100, Anton Khirnov wrote: > As previously for decoding, this is merely "scaffolding" for moving to a > fully threaded architecture and does not yet make filtering truly > parallel - the main thread will currently wait for the filtering thread > to finish its work before continuing. That will change in future commits > after encoders are also moved to threads and a thread-aware scheduler is > added. > --- > fftools/ffmpeg.h | 9 +- > fftools/ffmpeg_dec.c | 39 +- > fftools/ffmpeg_filter.c | 825 ++++++++++++++++++++++++++++++++++------ > 3 files changed, 730 insertions(+), 143 deletions(-) This seems to cause a new assertion failure with this: echo 'Call 0 ping' | ./ffmpeg -nostats -i mm-short.mpg -vf nullsink,color= =3Dgreen -bitexact -vframes 1 -f null - Press [q] to stop, [?] for help Enter command: |all