From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v6 0/7] webp: add support for animated WebP decoding
Date: Fri, 24 Nov 2023 22:02:55 +0100
Message-ID: <20231124210255.GG3543730@pb2> (raw)
In-Reply-To: <20231123114733.86103-1-thilo.borgmann@mail.de>
[-- Attachment #1.1: Type: text/plain, Size: 3167 bytes --]
On Thu, Nov 23, 2023 at 12:47:26PM +0100, Thilo Borgmann via ffmpeg-devel wrote:
> Still images fixed, includes FATE tests, VP8 decoder decoupled so there are no more data races, fixed more asserts.
>
> Patch 5/7 is still there for making changes in lavc/webp reviewable but shall be stashed when pushing.
>
> -Thilo
>
> Josef Zlomek (2):
> libavcodec/webp: add support for animated WebP decoding
> libavformat/webp: add WebP demuxer
>
> Thilo Borgmann (5):
> avcodec/webp: move definitions into header
> avcodec/webp: remove unused definitions
> avcodec/webp_parser: parse each frame into one packet
> avcodec/webp: make init_canvas_frame static
> fate: add test for animated WebP
>
> Changelog | 2 +
> doc/demuxers.texi | 28 +
> libavcodec/codec_desc.c | 3 +-
> libavcodec/version.h | 2 +-
> libavcodec/webp.c | 758 ++++++++++++++++++--
> libavcodec/webp.h | 38 +
> libavcodec/webp_parser.c | 130 ++--
> libavformat/Makefile | 1 +
> libavformat/allformats.c | 1 +
> libavformat/version.h | 2 +-
> libavformat/webpdec.c | 733 +++++++++++++++++++
> tests/fate/image.mak | 3 +
> tests/ref/fate/exif-image-webp | 12 +-
> tests/ref/fate/webp-anim | 22 +
> tests/ref/fate/webp-rgb-lena-lossless | 2 +-
> tests/ref/fate/webp-rgb-lena-lossless-rgb24 | 2 +-
> tests/ref/fate/webp-rgb-lossless | 2 +-
> tests/ref/fate/webp-rgb-lossy-q80 | 2 +-
> tests/ref/fate/webp-rgba-lossless | 2 +-
> tests/ref/fate/webp-rgba-lossy-q80 | 2 +-
> 20 files changed, 1625 insertions(+), 122 deletions(-)
> create mode 100644 libavcodec/webp.h
> create mode 100644 libavformat/webpdec.c
> create mode 100644 tests/ref/fate/webp-anim
seems t0 break fate
TEST exif-image-webp
--- ./tests/ref/fate/exif-image-webp 2023-11-24 21:28:14.398689445 +0100
+++ tests/data/fate/exif-image-webp 2023-11-24 22:02:25.856785635 +0100
@@ -8,12 +8,12 @@
pkt_dts_time=0.000000
best_effort_timestamp=0
best_effort_timestamp_time=0.000000
-pkt_duration=1
-pkt_duration_time=0.040000
-duration=1
-duration_time=0.040000
-pkt_pos=0
-pkt_size=39276
+pkt_duration=N/A
+pkt_duration_time=N/A
+duration=N/A
+duration_time=N/A
+pkt_pos=N/A
+pkt_size=N/A
width=400
height=225
crop_top=0
Test exif-image-webp failed. Look at tests/data/fate/exif-image-webp.err for details.
tests/Makefile:307: recipe for target 'fate-exif-image-webp' failed
make: *** [fate-exif-image-webp] Error 1
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-11-24 21:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 11:47 Thilo Borgmann via ffmpeg-devel
2023-11-23 11:47 ` [FFmpeg-devel] [PATCH v6 1/7] avcodec/webp: move definitions into header Thilo Borgmann via ffmpeg-devel
2023-11-23 11:47 ` [FFmpeg-devel] [PATCH v6 2/7] avcodec/webp: remove unused definitions Thilo Borgmann via ffmpeg-devel
2023-11-23 11:47 ` [FFmpeg-devel] [PATCH v6 3/7] avcodec/webp_parser: parse each frame into one packet Thilo Borgmann via ffmpeg-devel
2023-11-23 11:47 ` [FFmpeg-devel] [PATCH v6 4/7] libavcodec/webp: add support for animated WebP decoding Thilo Borgmann via ffmpeg-devel
2023-11-23 11:47 ` [FFmpeg-devel] [PATCH v6 5/7] avcodec/webp: make init_canvas_frame static Thilo Borgmann via ffmpeg-devel
2023-11-23 11:47 ` [FFmpeg-devel] [PATCH v6 6/7] libavformat/webp: add WebP demuxer Thilo Borgmann via ffmpeg-devel
2023-11-23 11:47 ` [FFmpeg-devel] [PATCH v6 7/7] fate: add test for animated WebP Thilo Borgmann via ffmpeg-devel
2023-11-24 21:02 ` Michael Niedermayer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231124210255.GG3543730@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git