From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 823F447CE3 for ; Fri, 17 Nov 2023 17:18:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8FF5168CA61; Fri, 17 Nov 2023 19:18:31 +0200 (EET) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0212568C6BA for ; Fri, 17 Nov 2023 19:18:24 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id C5BF7C0006 for ; Fri, 17 Nov 2023 17:18:23 +0000 (UTC) Date: Fri, 17 Nov 2023 18:18:22 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20231117171822.GR3543730@pb2> References: <20231116225012.GP3543730@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] cherrypick ab7926341 into 4.2 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3851594891870525010==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3851594891870525010== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="y6io0HLgd4HLg6mD" Content-Disposition: inline --y6io0HLgd4HLg6mD Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 17, 2023 at 07:11:13AM +0200, Martin Storsj=F6 wrote: > On Thu, 16 Nov 2023, Michael Niedermayer wrote: >=20 > > On Thu, Nov 16, 2023 at 02:35:58PM -0800, Reed Weichler wrote: > > > pretty self-explanatory. > > > i guess they forgot to cherrypick it when it was first committed. > > > here is my code to repro: https://pastebin.com/raw/yQr3WWvX > > > it needs a FLAC file as input. > > > it hit an EXC_BAD_ACCESS here: > > > https://github.com/FFmpeg/FFmpeg/blob/c6c36aa97a/libavformat/utils.c#= L2227 > > > index was equal to -1, so that code shouldnt even run, usually means = UB. > > > --- > > > libavformat/utils.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > >=20 > > > diff --git a/libavformat/utils.c b/libavformat/utils.c > > > index 4067d55fa1..2143d9fb59 100644 > > > --- a/libavformat/utils.c > > > +++ b/libavformat/utils.c > > > @@ -2183,7 +2183,7 @@ int ff_seek_frame_binary(AVFormatContext *s, int > > > stream_index, > >=20 > > patch corrupted by newline > >=20 > > patch locally backported to 4.2 - 4.4 >=20 > Instead of applying this patch, I'd suggest just doing a regular cherrypi= ck > of the referenced commit - ab7926341 - which would preserve both authorsh= ip > and the original commit message with the more accurate description of the > issue. thats exactly what i did and also to a few older branches thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Republics decline into democracies and democracies degenerate into despotisms. -- Aristotle --y6io0HLgd4HLg6mD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZVegWwAKCRBhHseHBAsP qw6uAKCPW+shsEfaxvEwRvBNwPrkuaRv8ACcCkAngyXUu2GHl/BFn/wsEQUCpB0= =gqtv -----END PGP SIGNATURE----- --y6io0HLgd4HLg6mD-- --===============3851594891870525010== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3851594891870525010==--