From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 52E7647CB5 for ; Thu, 16 Nov 2023 22:50:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C568368CCD8; Fri, 17 Nov 2023 00:50:19 +0200 (EET) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 263F368C9CD for ; Fri, 17 Nov 2023 00:50:14 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 53A1F40002 for ; Thu, 16 Nov 2023 22:50:13 +0000 (UTC) Date: Thu, 16 Nov 2023 23:50:12 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20231116225012.GP3543730@pb2> References: MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] cherrypick ab7926341 into 4.2 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8321050212036066690==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8321050212036066690== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3GJHkKoWZGuZb/0c" Content-Disposition: inline --3GJHkKoWZGuZb/0c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 16, 2023 at 02:35:58PM -0800, Reed Weichler wrote: > pretty self-explanatory. > i guess they forgot to cherrypick it when it was first committed. > here is my code to repro: https://pastebin.com/raw/yQr3WWvX > it needs a FLAC file as input. > it hit an EXC_BAD_ACCESS here: > https://github.com/FFmpeg/FFmpeg/blob/c6c36aa97a/libavformat/utils.c#L2227 > index was equal to -1, so that code shouldnt even run, usually means UB. > --- > libavformat/utils.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/libavformat/utils.c b/libavformat/utils.c > index 4067d55fa1..2143d9fb59 100644 > --- a/libavformat/utils.c > +++ b/libavformat/utils.c > @@ -2183,7 +2183,7 @@ int ff_seek_frame_binary(AVFormatContext *s, int > stream_index, patch corrupted by newline patch locally backported to 4.2 - 4.4 thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB "I am not trying to be anyone's saviour, I'm trying to think about the future and not be sad" - Elon Musk --3GJHkKoWZGuZb/0c Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZVacowAKCRBhHseHBAsP q5F6AJ9LpTpeRvx5dvX8J39fhopr7vhzRACghv+nADlaFndG9imZ8BxUbYTs4co= =tFsw -----END PGP SIGNATURE----- --3GJHkKoWZGuZb/0c-- --===============8321050212036066690== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8321050212036066690==--