From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0F0F048297 for ; Wed, 15 Nov 2023 21:46:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3B83968CD2A; Wed, 15 Nov 2023 23:45:57 +0200 (EET) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 14F5668CBF0 for ; Wed, 15 Nov 2023 23:45:51 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 63F5FE0003 for ; Wed, 15 Nov 2023 21:45:50 +0000 (UTC) Date: Wed, 15 Nov 2023 22:45:49 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20231115214549.GN3543730@pb2> References: <0f21e4f846a1190521896ed7f3a23ffc8993589a.camel@haerdin.se> <2638aec6-49ff-4714-8158-9de42bd9c69a@nativewaves.com> MIME-Version: 1.0 In-Reply-To: <2638aec6-49ff-4714-8158-9de42bd9c69a@nativewaves.com> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH v2 0/6] WebRTC sub-second live streaming support X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3666563754687626677==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3666563754687626677== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hU9LknB+3OmvxnUX" Content-Disposition: inline --hU9LknB+3OmvxnUX Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 14, 2023 at 01:59:48PM +0100, Michael Riedl wrote: > On 11/14/23 11:05, Tomas H=E4rdin wrote: > > This patchset is missing tests. I know that we for some reason don't > > really have tests for protocols, but I feel the issue is worthwhile to > > bring up. I've worked a bit with WebRTC recently and it's fiddly, so > > it'd be nice to have some automated thing that keeps track of which > > WebRTC implementations this works with. Or maybe this is better handled > > with an external project, testing which implementations interoperate? >=20 >=20 > I agree that having automated tests would be useful for stability in the = future. > I tested the patchset with both SRS and Millicast, and it worked well. >=20 > For automated testing, we could use FATE, but it needs an extra server wi= th > protection and someone to keep it updated. Testing with paid services like > Millicast is tricky. >=20 > Another option is an external project for WebRTC testing, but the challen= ge is > keeping it maintained and compatible with changes in implementations. >=20 > External services might update their software, causing issues with tests.= We > would need a plan for dealing with that. >=20 > For paid services like Millicast, we need to figure out who pays for the = tests. > Understanding the costs is essential if we want to use paid services for > testing. >=20 > I'd like to hear your thoughts on these points and how you would propose = to > proceed with adding tests for protocols like WebRTC. simple, add server support for this to FFmpeg. FATE is run in cases without network access (for example googles ossfuzz se= tup i belives does not permit the fuzzed code to access external things IIRC) The practice of implementing only one end of a protocol is honestly wrong. And if there is no usable free server, then even more so. thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If you drop bombs on a foreign country and kill a hundred thousand innocent people, expect your government to call the consequence "unprovoked inhuman terrorist attacks" and use it to justify dropping more bombs and killing more people. The technology changed, the idea is old. --hU9LknB+3OmvxnUX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZVU8BgAKCRBhHseHBAsP q0n9AKCHaKXaS2CFXS2IjIrfqZCAfH9mcwCbBYxk9k+ELnMdyk4w4uaxyMdPsYA= =wdPp -----END PGP SIGNATURE----- --hU9LknB+3OmvxnUX-- --===============3666563754687626677== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3666563754687626677==--