Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2 0/6] WebRTC sub-second live streaming support
Date: Wed, 15 Nov 2023 22:45:49 +0100
Message-ID: <20231115214549.GN3543730@pb2> (raw)
In-Reply-To: <2638aec6-49ff-4714-8158-9de42bd9c69a@nativewaves.com>


[-- Attachment #1.1: Type: text/plain, Size: 2229 bytes --]

On Tue, Nov 14, 2023 at 01:59:48PM +0100, Michael Riedl wrote:
> On 11/14/23 11:05, Tomas Härdin wrote:
> > This patchset is missing tests. I know that we for some reason don't
> > really have tests for protocols, but I feel the issue is worthwhile to
> > bring up. I've worked a bit with WebRTC recently and it's fiddly, so
> > it'd be nice to have some automated thing that keeps track of which
> > WebRTC implementations this works with. Or maybe this is better handled
> > with an external project, testing which implementations interoperate?
> 
> 
> I agree that having automated tests would be useful for stability in the future.
> I tested the patchset with both SRS and Millicast, and it worked well.
> 
> For automated testing, we could use FATE, but it needs an extra server with
> protection and someone to keep it updated. Testing with paid services like
> Millicast is tricky.
> 
> Another option is an external project for WebRTC testing, but the challenge is
> keeping it maintained and compatible with changes in implementations.
> 
> External services might update their software, causing issues with tests. We
> would need a plan for dealing with that.
> 
> For paid services like Millicast, we need to figure out who pays for the tests.
> Understanding the costs is essential if we want to use paid services for
> testing.
> 
> I'd like to hear your thoughts on these points and how you would propose to
> proceed with adding tests for protocols like WebRTC.

simple, add server support for this to FFmpeg.

FATE is run in cases without network access (for example googles ossfuzz setup
i belives does not permit the fuzzed code to access external things IIRC)

The practice of implementing only one end of a protocol is honestly wrong.
And if there is no usable free server, then even more so.

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you drop bombs on a foreign country and kill a hundred thousand
innocent people, expect your government to call the consequence
"unprovoked inhuman terrorist attacks" and use it to justify dropping
more bombs and killing more people. The technology changed, the idea is old.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2023-11-15 21:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-07 14:12 Michael Riedl
2023-11-14 10:05 ` Tomas Härdin
2023-11-14 12:59   ` Michael Riedl
2023-11-14 15:46     ` Tomas Härdin
2023-11-15 21:45     ` Michael Niedermayer [this message]
2023-11-27  9:46       ` Michael Riedl
2023-11-27  9:48         ` Nicolas George

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231115214549.GN3543730@pb2 \
    --to=michael@niedermayer.cc \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git