From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1697A480F4 for ; Thu, 9 Nov 2023 22:16:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 983D268CB89; Fri, 10 Nov 2023 00:16:47 +0200 (EET) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1BE5768CA29 for ; Fri, 10 Nov 2023 00:16:41 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 7E9DFE0003 for ; Thu, 9 Nov 2023 22:16:40 +0000 (UTC) Date: Thu, 9 Nov 2023 23:16:39 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20231109221639.GH3543730@pb2> References: <169952480359.11195.9525129954974840844@lain.khirnov.net> <15041633.235GFhGzie@basile.remlab.net> MIME-Version: 1.0 In-Reply-To: <15041633.235GFhGzie@basile.remlab.net> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo: Remove spec-incompliant inverse quantisation X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6463351879653735833==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6463351879653735833== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="YplL10PiYs6Vi4zX" Content-Disposition: inline --YplL10PiYs6Vi4zX Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 09, 2023 at 10:52:19PM +0200, R=E9mi Denis-Courmont wrote: > Le torstaina 9. marraskuuta 2023, 22.45.35 EET Alexander Strasser a =E9cr= it : > > I can't see how the reason for the presence of code can be ultimately > > defined objectively and non-arbitrary. >=20 > Ultimately, this was discussed and decided in a meeting, which Michael=20 > attended (albeit remotely) and for which meeting notes were published. maybe i misremember as i was a bit sick that day but there are 2 pieces of code there was the "fast mode code" that i thought was discussed this is disabled by default and we aggreed to remove it the change here is about the default code path so this is very different it will affect users with default options. I do not remember this was discussed but its quite possible people had a different interpretation what the words meant that where said. This definitly should be tested before its applied. Whoever the burden falls on is not my argument but ATM i have many things to do so i will not be able to test this in the next days >=20 > That being the case, I don't see why Andreas should have to perform exten= sive=20 > testing and write extensive justification. He could have done and that wo= uld=20 > have been nice, but that is all. I never meant that there should be extensive testing but teh removal of a optimization from the default codepath should be tested. Also about spec non compliance, if this was so bad, being in the default path there would be bug reports so iam a bit sceptic. not saying it shouldnt be removed just saying we should look before removing it thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I have often repented speaking, but never of holding my tongue. -- Xenocrates --YplL10PiYs6Vi4zX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZU1aRAAKCRBhHseHBAsP q4UqAKCTIuxZY4pCskwQm0g3bRVzEBeVPQCfUwMg8o9T4+BF5TibDByYpKUYs+Y= =OooK -----END PGP SIGNATURE----- --YplL10PiYs6Vi4zX-- --===============6463351879653735833== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6463351879653735833==--