From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1BD2648085 for ; Thu, 9 Nov 2023 12:26:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CBD4B68CBDF; Thu, 9 Nov 2023 14:25:47 +0200 (EET) Received: from haasn.dev (haasn.dev [78.46.187.166]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EFA9968CBDC for ; Thu, 9 Nov 2023 14:25:36 +0200 (EET) Received: from haasn.dev (unknown [10.30.0.2]) by haasn.dev (Postfix) with ESMTP id B007A4BB22; Thu, 9 Nov 2023 13:25:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=haasn.xyz; s=mail; t=1699532736; bh=Lt2U3qANIACK/9ke9adoboGOHB7sOeWQnsnAsX9IZKw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tcb1FrGjlMr7wS01VvQsXSSUIvnvyBVNXaE+8sCydTTLv5xRtgx6a+li41p6mNwpU Ut89LcKqY5lYoXjlNhR5epvMydOev37HhpV6ogfD9KzBdv1786vyWQl0GAzWUzvMOX BP4IBrfHQDi/jfr4BygyfiqjxbIhtGkdM8IOrm+M= From: Niklas Haas To: ffmpeg-devel@ffmpeg.org Date: Thu, 9 Nov 2023 13:19:36 +0100 Message-ID: <20231109122534.124157-5-ffmpeg@haasn.xyz> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231109122534.124157-1-ffmpeg@haasn.xyz> References: <20231109122534.124157-1-ffmpeg@haasn.xyz> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 04/25] fftools/ffmpeg_filter: don't clear buffersrc params X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Niklas Haas Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: Niklas Haas This memset is bogus, it accomplishes nothing in the best case and regresses future additions to AVBufferSrcParameters in the worst case. --- fftools/ffmpeg_filter.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index b7da105141..e699798897 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -1400,11 +1400,8 @@ static int configure_input_video_filter(FilterGraph *fg, InputFilter *ifilter, int ret, pad_idx = 0; int64_t tsoffset = 0; AVBufferSrcParameters *par = av_buffersrc_parameters_alloc(); - if (!par) return AVERROR(ENOMEM); - memset(par, 0, sizeof(*par)); - par->format = AV_PIX_FMT_NONE; if (ist->dec_ctx->codec_type == AVMEDIA_TYPE_AUDIO) { av_log(fg, AV_LOG_ERROR, "Cannot connect video filter to audio input\n"); -- 2.42.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".