From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BFD934613A for ; Sat, 4 Nov 2023 18:44:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4D8DE68CE75; Sat, 4 Nov 2023 20:44:17 +0200 (EET) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id ECA8E68CDA3 for ; Sat, 4 Nov 2023 20:44:10 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 1A5B31BF203 for ; Sat, 4 Nov 2023 18:44:09 +0000 (UTC) Date: Sat, 4 Nov 2023 19:44:09 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20231104184409.GI3543730@pb2> References: <20231104092125.10213-1-anton@khirnov.net> <20231104092125.10213-19-anton@khirnov.net> MIME-Version: 1.0 In-Reply-To: <20231104092125.10213-19-anton@khirnov.net> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 18/24] fftools/ffmpeg: add thread-aware transcode scheduling infrastructure X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4256030382176574364==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4256030382176574364== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9BEftvsWSBwErx21" Content-Disposition: inline --9BEftvsWSBwErx21 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 04, 2023 at 08:56:27AM +0100, Anton Khirnov wrote: > See the comment block at the top of fftools/ffmpeg_sched.h for more > details on what this scheduler is for. >=20 > This commit adds the scheduling code itself, along with minimal > integration with the rest of the program: > * allocating and freeing the scheduler > * passing it throughout the call stack in order to register the > individual components (demuxers/decoders/filtergraphs/encoders/muxers) > with the scheduler >=20 > The scheduler is not actually used as of this commit, so it should not > result in any change in behavior. That will change in future commits. > --- > fftools/Makefile | 1 + > fftools/ffmpeg.c | 18 +- > fftools/ffmpeg.h | 24 +- > fftools/ffmpeg_dec.c | 10 +- > fftools/ffmpeg_demux.c | 46 +- > fftools/ffmpeg_enc.c | 13 +- > fftools/ffmpeg_filter.c | 37 +- > fftools/ffmpeg_mux.c | 17 +- > fftools/ffmpeg_mux.h | 11 + > fftools/ffmpeg_mux_init.c | 82 +- > fftools/ffmpeg_opt.c | 22 +- > fftools/ffmpeg_sched.c | 2072 +++++++++++++++++++++++++++++++++++++ > fftools/ffmpeg_sched.h | 461 +++++++++ > 13 files changed, 2758 insertions(+), 56 deletions(-) > create mode 100644 fftools/ffmpeg_sched.c > create mode 100644 fftools/ffmpeg_sched.h Is fate intended to pass for each point in the patchset ? make -j32 fate-h264-skip-nointra seems to fail after this [h264 @ 0x5598133bccc0] non-existing PPS 0 referenced Last message repeated 5 times [h264 @ 0x5598133bccc0] decode_slice_header error [h264 @ 0x5598133bccc0] non-existing PPS 0 referenced Last message repeated 1 times [h264 @ 0x5598133bccc0] decode_slice_header error [h264 @ 0x5598133bccc0] non-existing PPS 0 referenced Last message repeated 1 times [h264 @ 0x5598133bccc0] decode_slice_header error [h264 @ 0x5598133bccc0] non-existing PPS 0 referenced Last message repeated 1 times [h264 @ 0x5598133bccc0] decode_slice_header error [h264 @ 0x5598133bccc0] non-existing PPS 0 referenced Last message repeated 3 times [h264 @ 0x5598133bccc0] mmco: unref short failure Last message repeated 1 times [h264 @ 0x5598133bccc0] number of reference frames (0+4) exceeds max (3; pr= obably corrupt input), discarding one [mpegts @ 0x5598133b7080] PES packet size mismatch [mpegts @ 0x5598133b7080] Packet corrupt (stream =3D 2, dts =3D 212088417). [mpegts @ 0x5598133b7080] PES packet size mismatch [mpegts @ 0x5598133b7080] Packet corrupt (stream =3D 1, dts =3D 212089857). [mpegts @ 0x5598133b7080] PES packet size mismatch [mpegts @ 0x5598133b7080] Packet corrupt (stream =3D 2, dts =3D 212088417). [mpegts @ 0x5598133b7080] PES packet size mismatch [mpegts @ 0x5598133b7080] Packet corrupt (stream =3D 1, dts =3D 212089857). Input #0, mpegts, from 'fatesamples/fate/fate-suite//h264/h264_intra_first-= small.ts': Duration: 00:00:02.48, start: 2355.577967, bitrate: 4961 kb/s Program 41 Stream #0:0[0x12b5]: Video: h264 (High) ([27][0][0][0] / 0x001B), yuv420p= (tv, bt709, top first), 1920x1080 [SAR 1:1 DAR 16:9], 25 fps, 50 tbr, 90k t= bn Stream #0:1[0x12b4](swe): Audio: mp2 ([3][0][0][0] / 0x0003), 48000 Hz, s= tereo, fltp, 224 kb/s Stream #0:2[0x12b2](nor): Audio: mp2 ([3][0][0][0] / 0x0003), 48000 Hz, s= tereo, fltp, 224 kb/s Stream mapping: Stream #0:0 -> #0:0 (h264 (native) -> rawvideo (native)) Stream #0:1 -> #0:1 (mp2 (native) -> pcm_s16le (native)) [aost#0:1/pcm_s16le @ 0x5598134536c0] Too many packets buffered for output = stream 0:1. [aost#0:1/pcm_s16le @ 0x5598134536c0] Error submitting a packet to the muxe= r: No space left on deviceError while filtering: No space left on device [out#0/framecrc @ 0x5598133bedc0] Nothing was written into output file, bec= ause at least one of its streams received no packets. frame=3D 0 fps=3D0.0 q=3D0.0 Lsize=3D 0kB time=3D00:00:00.19 bitra= te=3D 0.0kbits/s speed=3D68.4x Conversion failed! threads=3D1 tests/Makefile:307: recipe for target 'fate-h264-skip-nointra' failed make: *** [fate-h264-skip-nointra] Error 228 [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Dictatorship: All citizens are under surveillance, all their steps and actions recorded, for the politicians to enforce control. Democracy: All politicians are under surveillance, all their steps and actions recorded, for the citizens to enforce control. --9BEftvsWSBwErx21 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZUaQ9QAKCRBhHseHBAsP q71mAJ9bcoJgDphQHc+6Iu1TaTkj/RSkYQCgkMOEqwcAtMWnJ6wGs9kQ860QcEs= =w5CE -----END PGP SIGNATURE----- --9BEftvsWSBwErx21-- --===============4256030382176574364== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4256030382176574364==--