From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CBB4E4559D for ; Sat, 4 Nov 2023 17:41:46 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3015368CE66; Sat, 4 Nov 2023 19:41:44 +0200 (EET) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7434068CE27 for ; Sat, 4 Nov 2023 19:41:37 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 818DDE0002 for ; Sat, 4 Nov 2023 17:41:36 +0000 (UTC) Date: Sat, 4 Nov 2023 18:41:35 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20231104174135.GG3543730@pb2> References: <1e243762-a5bf-4374-a39f-3ed846caa4d5@gmail.com> MIME-Version: 1.0 In-Reply-To: <1e243762-a5bf-4374-a39f-3ed846caa4d5@gmail.com> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 1/2] decode: add ff_decode_skip_samples function X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6078398894657603599==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6078398894657603599== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Oo39OE1Q8R9Sqf8A" Content-Disposition: inline --Oo39OE1Q8R9Sqf8A Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 04, 2023 at 04:22:11PM +0000, Derek Buitenhuis wrote: [...] > I am almost certain I missed even more nuance, and hopefully Martin or An= ton can chime in, or I remember more. >=20 > But also, given all of this, I think we need to deeply consider how we ap= proach this, so we don't end up with > something that only covers certain cases (and I am sure I forgot more cas= es). To that end, I do not think rushing > to get a patchset that can change sync on all AAC files in existence into= 6.1 is wise. Even when this does go in, > it should be able to sit in master for a good long time before being in a= release. As I understand it, FATE is > already unhappy, and it shouldn't be treated as being a problem with FATE= vs the set. >=20 > Lastly, some time this weekend/week, I will labour to create a more exten= sive set of AAC files we can use to > test, and use in FATE. I think thats a very good idea. Ideally we would have a set of test samples encoded with all major encoders samples where start, end and sync can be easily determined unambigously once we have such a set, it becomes easy to check that we get the start/end= /sync right for every file by default. I think the guiding principle should be that what comes out of the decoder = is as close to what went into the encoder. And of course to comply to specific= ations > > Hope that all made sense and I didn't forget any details in my Covid-indu= ced haze. i hope you get better soon! thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Good people do not need laws to tell them to act responsibly, while bad people will find a way around the laws. -- Plato --Oo39OE1Q8R9Sqf8A Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZUaCSAAKCRBhHseHBAsP q+sKAJ9XWQgr6fqRys4XAq9G1K5U3PixxgCeIfLdyv94tzUY8Qj9zTyQm2T6H/Q= =Maj/ -----END PGP SIGNATURE----- --Oo39OE1Q8R9Sqf8A-- --===============6078398894657603599== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6078398894657603599==--