From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DB6FB4723A for ; Tue, 31 Oct 2023 13:28:55 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D5ADB68CCF9; Tue, 31 Oct 2023 15:28:52 +0200 (EET) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1E2AC68CB94 for ; Tue, 31 Oct 2023 15:28:46 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 2EA761C0002 for ; Tue, 31 Oct 2023 13:28:44 +0000 (UTC) Date: Tue, 31 Oct 2023 14:28:44 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20231031132844.GR3543730@pb2> References: <20231030010549.59349-1-toots@rastageeks.org> MIME-Version: 1.0 In-Reply-To: <20231030010549.59349-1-toots@rastageeks.org> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] Extract av_hls_codec_attr X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1379681569092489372==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1379681569092489372== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="julKvlZmpqRbCJ+2" Content-Disposition: inline --julKvlZmpqRbCJ+2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 29, 2023 at 08:05:50PM -0500, Romain Beauxis wrote: > The logic for extracting HLS codec attribute strings is very useful and > can be re-used in many different situations when working with HLS > streams using libavcodec/libavformat. >=20 > This patch extracts the function's code and places it into a publicly > available function. >=20 > --- > libavcodec/Makefile | 2 + > libavcodec/hls.c | 105 +++++++++++++++++++++++++++++++++++++++++++ > libavcodec/hls.h | 42 +++++++++++++++++ > libavformat/hlsenc.c | 83 +++------------------------------- you cannot call ff_* functions across libs they need to start with av* / avpriv* [...] > + rbsp_buf =3D ff_nal_unit_extract_rbsp(data, remain_size, &= rbsp_size, 0); libavcodec/libavcodec.so: undefined reference to `ff_nal_unit_extract_rbsp' clang: error: linker command failed with exit code 1 (use -v to see invocat= ion) Makefile:133: recipe for target 'ffmpeg_g' failed make: *** [ffmpeg_g] Error 1 make: *** Waiting for unfinished jobs.... libavcodec/libavcodec.so: undefined reference to `ff_nal_unit_extract_rbsp' clang: error: linker command failed with exit code 1 (use -v to see invocat= ion) Makefile:133: recipe for target 'ffplay_g' failed make: *** [ffplay_g] Error 1 thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If a bugfix only changes things apparently unrelated to the bug with no further explanation, that is a good sign that the bugfix is wrong. --julKvlZmpqRbCJ+2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZUEBCQAKCRBhHseHBAsP qx6aAJkBkKnGdoDtFspVMkigIfcGrT7S6ACdFoRw9FH4RgpRJq89refp2xtx/Mg= =0t3M -----END PGP SIGNATURE----- --julKvlZmpqRbCJ+2-- --===============1379681569092489372== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1379681569092489372==--