From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] Extract av_hls_codec_attr
Date: Tue, 31 Oct 2023 14:28:44 +0100
Message-ID: <20231031132844.GR3543730@pb2> (raw)
In-Reply-To: <20231030010549.59349-1-toots@rastageeks.org>
[-- Attachment #1.1: Type: text/plain, Size: 1531 bytes --]
On Sun, Oct 29, 2023 at 08:05:50PM -0500, Romain Beauxis wrote:
> The logic for extracting HLS codec attribute strings is very useful and
> can be re-used in many different situations when working with HLS
> streams using libavcodec/libavformat.
>
> This patch extracts the function's code and places it into a publicly
> available function.
>
> ---
> libavcodec/Makefile | 2 +
> libavcodec/hls.c | 105 +++++++++++++++++++++++++++++++++++++++++++
> libavcodec/hls.h | 42 +++++++++++++++++
> libavformat/hlsenc.c | 83 +++-------------------------------
you cannot call ff_* functions across libs
they need to start with av* / avpriv*
[...]
> + rbsp_buf = ff_nal_unit_extract_rbsp(data, remain_size, &rbsp_size, 0);
libavcodec/libavcodec.so: undefined reference to `ff_nal_unit_extract_rbsp'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Makefile:133: recipe for target 'ffmpeg_g' failed
make: *** [ffmpeg_g] Error 1
make: *** Waiting for unfinished jobs....
libavcodec/libavcodec.so: undefined reference to `ff_nal_unit_extract_rbsp'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Makefile:133: recipe for target 'ffplay_g' failed
make: *** [ffplay_g] Error 1
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-10-31 13:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 1:05 Romain Beauxis
2023-10-31 13:28 ` Michael Niedermayer [this message]
2023-11-03 5:20 ` Romain Beauxis
2023-10-31 16:47 ` Zhao Zhili
2023-11-03 5:21 ` Romain Beauxis
2023-11-03 5:28 ` Zhao Zhili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231031132844.GR3543730@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git