From: Niklas Haas <ffmpeg@haasn.xyz>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2 07/10] avfilter/vf_scale: preserve YUV range by default
Date: Tue, 31 Oct 2023 12:23:58 +0100
Message-ID: <20231031122358.GB16818@haasn.xyz> (raw)
In-Reply-To: <20231030234247.GN3543730@pb2>
On Tue, 31 Oct 2023 00:42:47 +0100 Michael Niedermayer <michael@niedermayer.cc> wrote:
> On Sat, Oct 28, 2023 at 04:41:14PM +0200, Niklas Haas wrote:
> > From: Niklas Haas <git@haasn.dev>
> >
> > YUV->YUV conversions should preserve input range, if the output range is
> > unspecified. Ensures full-range YUV input comes out as full-range YUV
> > output by default, even through YUV->YUV pixel format conversions.
> > ---
> > libavfilter/vf_scale.c | 23 +++++++++++++++++++++++
> > 1 file changed, 23 insertions(+)
>
> this seems to change the output of the following:
> ffmpeg -i 4493/AVCI100.mov -vframes 3 -bitexact file.nut
> did not investigate if this is a bug or bugfix
>
> files are here: https://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket524/
Seems like it's a regression. mpeg4 does not support full range YUV, so
giving it full range YUV causes wrong levels to be saved.
I will drop this commit from this series and include it as part of the
filter negotiation series, since that one has the necessary
infrastructure to handle this more gracefully.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-10-31 11:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-28 14:41 [FFmpeg-devel] [PATCH v2 00/10] YUVJ removal preliminary cleanup Niklas Haas
2023-10-28 14:41 ` [FFmpeg-devel] [PATCH v2 01/10] swscale: fix sws_setColorspaceDetails after sws_init_context Niklas Haas
2023-10-28 14:41 ` [FFmpeg-devel] [PATCH v2 02/10] swscale: don't omit ff_sws_init_range_convert for high-bit Niklas Haas
2023-10-28 14:41 ` [FFmpeg-devel] [PATCH v2 03/10] swscale/yuv2rgb: fix sws_getCoefficients for colorspace=0 Niklas Haas
2023-10-28 14:41 ` [FFmpeg-devel] [PATCH v2 04/10] avfilter/vf_extractplanes: tag alpha plane as full range Niklas Haas
2023-10-28 14:41 ` [FFmpeg-devel] [PATCH v2 05/10] avfilter/vf_alphamerge: warn if input not " Niklas Haas
2023-10-28 14:41 ` [FFmpeg-devel] [PATCH v2 06/10] avfilter/vf_scale: properly respect to input colorimetry Niklas Haas
2023-10-31 12:18 ` Niklas Haas
2023-10-28 14:41 ` [FFmpeg-devel] [PATCH v2 07/10] avfilter/vf_scale: preserve YUV range by default Niklas Haas
2023-10-30 23:42 ` Michael Niedermayer
2023-10-31 11:23 ` Niklas Haas [this message]
2023-10-28 14:41 ` [FFmpeg-devel] [PATCH v2 08/10] avfilter/vf_scale: simplify color matrix parsing logic Niklas Haas
2023-10-28 14:41 ` [FFmpeg-devel] [PATCH v2 09/10] avfilter/vf_scale: tag output color space Niklas Haas
2023-10-28 14:41 ` [FFmpeg-devel] [PATCH v2 10/10] avcodec/pnm: explicitly tag color range Niklas Haas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231031122358.GB16818@haasn.xyz \
--to=ffmpeg@haasn.xyz \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git