From: Reimar.Doeffinger@gmx.de
To: ffmpeg-devel@ffmpeg.org
Cc: "Reimar Döffinger" <Reimar.Doeffinger@gmx.de>
Subject: [FFmpeg-devel] [PATCH 3/3] libavutil/log.c: only include valgrind header when used.
Date: Sun, 29 Oct 2023 18:56:57 +0100
Message-ID: <20231029175657.46386-3-Reimar.Doeffinger@gmx.de> (raw)
In-Reply-To: <20231029175657.46386-1-Reimar.Doeffinger@gmx.de>
From: Reimar Döffinger <Reimar.Doeffinger@gmx.de>
This is cleaner, but it is also a workaround for when
the header exists, but cannot be compiled.
This will happen when the compiler has no inline asm
support.
Possibly the configure check should be improved as well.
---
libavutil/log.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavutil/log.c b/libavutil/log.c
index 5948e50467..2d358b7ab9 100644
--- a/libavutil/log.c
+++ b/libavutil/log.c
@@ -47,7 +47,7 @@ static AVMutex mutex = AV_MUTEX_INITIALIZER;
#define LINE_SZ 1024
-#if HAVE_VALGRIND_VALGRIND_H
+#if HAVE_VALGRIND_VALGRIND_H && CONFIG_VALGRIND_BACKTRACE
#include <valgrind/valgrind.h>
/* this is the log level at which valgrind will output a full backtrace */
#define BACKTRACE_LOGLEVEL AV_LOG_ERROR
--
2.39.3 (Apple Git-145)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-10-29 17:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-29 17:56 [FFmpeg-devel] [PATCH 1/3] configure: fix _Pragma check Reimar.Doeffinger
2023-10-29 17:56 ` [FFmpeg-devel] [PATCH 2/3] libavutil/aarch64/cpu.c: HWCAPS requires inline asm support Reimar.Doeffinger
2023-10-29 20:49 ` Martin Storsjö
2023-10-29 17:56 ` Reimar.Doeffinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231029175657.46386-3-Reimar.Doeffinger@gmx.de \
--to=reimar.doeffinger@gmx.de \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git