From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 963E947A19 for ; Sun, 29 Oct 2023 13:13:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A398968CAC2; Sun, 29 Oct 2023 15:13:56 +0200 (EET) Received: from ursule.remlab.net (vps-a2bccee9.vps.ovh.net [51.75.19.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 12C9B68C3E2 for ; Sun, 29 Oct 2023 15:13:50 +0200 (EET) Received: from basile.remlab.net (localhost [IPv6:::1]) by ursule.remlab.net (Postfix) with ESMTP id 6DA77C006F for ; Sun, 29 Oct 2023 15:13:49 +0200 (EET) From: =?UTF-8?q?R=C3=A9mi=20Denis-Courmont?= To: ffmpeg-devel@ffmpeg.org Date: Sun, 29 Oct 2023 15:13:49 +0200 Message-ID: <20231029131349.73027-1-remi@remlab.net> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] lavc/pixblockdsp: remove R-V V get_pixels_16 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: In the aligned case, the existing RVI assembler is actually much faster. In the unaligned case, there is nothing much to gain over C. --- libavcodec/riscv/pixblockdsp_init.c | 7 +------ libavcodec/riscv/pixblockdsp_rvv.S | 7 ------- 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/libavcodec/riscv/pixblockdsp_init.c b/libavcodec/riscv/pixblockdsp_init.c index 7d259a032f..6b1efd16f8 100644 --- a/libavcodec/riscv/pixblockdsp_init.c +++ b/libavcodec/riscv/pixblockdsp_init.c @@ -36,8 +36,6 @@ void ff_get_pixels_8_rvv(int16_t *block, const uint8_t *pixels, ptrdiff_t stride); void ff_get_pixels_unaligned_8_rvv(int16_t *block, const uint8_t *pixels, ptrdiff_t stride); -void ff_get_pixels_unaligned_16_rvv(int16_t *block, const uint8_t *pixels, - ptrdiff_t stride); void ff_diff_pixels_rvv(int16_t *block, const uint8_t *s1, const uint8_t *s2, ptrdiff_t stride); void ff_diff_pixels_unaligned_rvv(int16_t *block, const uint8_t *s1, @@ -58,10 +56,7 @@ av_cold void ff_pixblockdsp_init_riscv(PixblockDSPContext *c, #if HAVE_RVV if ((cpu_flags & AV_CPU_FLAG_RVV_I32) && ff_get_rv_vlenb() >= 16) { - if (high_bit_depth) { - c->get_pixels = ff_get_pixels_unaligned_16_rvv; - c->get_pixels_unaligned = ff_get_pixels_unaligned_16_rvv; - } else { + if (!high_bit_depth) { c->get_pixels = ff_get_pixels_unaligned_8_rvv; c->get_pixels_unaligned = ff_get_pixels_unaligned_8_rvv; } diff --git a/libavcodec/riscv/pixblockdsp_rvv.S b/libavcodec/riscv/pixblockdsp_rvv.S index 80c7415acf..7e35fc5b46 100644 --- a/libavcodec/riscv/pixblockdsp_rvv.S +++ b/libavcodec/riscv/pixblockdsp_rvv.S @@ -45,13 +45,6 @@ func ff_get_pixels_unaligned_8_rvv, zve32x ret endfunc -func ff_get_pixels_unaligned_16_rvv, zve32x - vsetivli zero, 8, e16, m1, ta, ma - vlsseg8e16.v v0, (a1), a2 - vsseg8e16.v v0, (a0) - ret -endfunc - func ff_diff_pixels_rvv, zve64x vsetivli zero, 8, e8, mf2, ta, ma li t0, 8 * 8 -- 2.42.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".