From: "Rémi Denis-Courmont" <remi@remlab.net> To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH] lavc/pixblockdsp: remove R-V V get_pixels_16 Date: Sun, 29 Oct 2023 15:13:49 +0200 Message-ID: <20231029131349.73027-1-remi@remlab.net> (raw) In the aligned case, the existing RVI assembler is actually much faster. In the unaligned case, there is nothing much to gain over C. --- libavcodec/riscv/pixblockdsp_init.c | 7 +------ libavcodec/riscv/pixblockdsp_rvv.S | 7 ------- 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/libavcodec/riscv/pixblockdsp_init.c b/libavcodec/riscv/pixblockdsp_init.c index 7d259a032f..6b1efd16f8 100644 --- a/libavcodec/riscv/pixblockdsp_init.c +++ b/libavcodec/riscv/pixblockdsp_init.c @@ -36,8 +36,6 @@ void ff_get_pixels_8_rvv(int16_t *block, const uint8_t *pixels, ptrdiff_t stride); void ff_get_pixels_unaligned_8_rvv(int16_t *block, const uint8_t *pixels, ptrdiff_t stride); -void ff_get_pixels_unaligned_16_rvv(int16_t *block, const uint8_t *pixels, - ptrdiff_t stride); void ff_diff_pixels_rvv(int16_t *block, const uint8_t *s1, const uint8_t *s2, ptrdiff_t stride); void ff_diff_pixels_unaligned_rvv(int16_t *block, const uint8_t *s1, @@ -58,10 +56,7 @@ av_cold void ff_pixblockdsp_init_riscv(PixblockDSPContext *c, #if HAVE_RVV if ((cpu_flags & AV_CPU_FLAG_RVV_I32) && ff_get_rv_vlenb() >= 16) { - if (high_bit_depth) { - c->get_pixels = ff_get_pixels_unaligned_16_rvv; - c->get_pixels_unaligned = ff_get_pixels_unaligned_16_rvv; - } else { + if (!high_bit_depth) { c->get_pixels = ff_get_pixels_unaligned_8_rvv; c->get_pixels_unaligned = ff_get_pixels_unaligned_8_rvv; } diff --git a/libavcodec/riscv/pixblockdsp_rvv.S b/libavcodec/riscv/pixblockdsp_rvv.S index 80c7415acf..7e35fc5b46 100644 --- a/libavcodec/riscv/pixblockdsp_rvv.S +++ b/libavcodec/riscv/pixblockdsp_rvv.S @@ -45,13 +45,6 @@ func ff_get_pixels_unaligned_8_rvv, zve32x ret endfunc -func ff_get_pixels_unaligned_16_rvv, zve32x - vsetivli zero, 8, e16, m1, ta, ma - vlsseg8e16.v v0, (a1), a2 - vsseg8e16.v v0, (a0) - ret -endfunc - func ff_diff_pixels_rvv, zve64x vsetivli zero, 8, e8, mf2, ta, ma li t0, 8 * 8 -- 2.42.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
reply other threads:[~2023-10-29 13:13 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20231029131349.73027-1-remi@remlab.net \ --to=remi@remlab.net \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git