Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Niklas Haas <ffmpeg@haasn.xyz>
To: ffmpeg-devel@ffmpeg.org
Cc: Niklas Haas <git@haasn.dev>
Subject: Re: [FFmpeg-devel] [PATCH 6/8] avfilter/vf_scale: simplify color matrix parsing logic
Date: Sat, 28 Oct 2023 15:31:32 +0200
Message-ID: <20231028153132.GB43691@haasn.xyz> (raw)
In-Reply-To: <20231027170446.63684-6-ffmpeg@haasn.xyz>

On Fri, 27 Oct 2023 19:04:44 +0200 Niklas Haas <ffmpeg@haasn.xyz> wrote:
> -    {  "in_color_matrix", "set input YCbCr type",   OFFSET(in_color_matrix),  AV_OPT_TYPE_STRING, { .str = "auto" }, .flags = FLAGS, "color" },
> -    { "out_color_matrix", "set output YCbCr type",  OFFSET(out_color_matrix), AV_OPT_TYPE_STRING, { .str = NULL }, .flags = FLAGS,  "color"},
> +    {  "in_color_matrix", "set input YCbCr type",   OFFSET(in_color_matrix),  AV_OPT_TYPE_INT, { .i64 = AVCOL_SPC_UNSPECIFIED }, 0, AVCOL_SPC_NB-1, .flags = FLAGS, "color" },
> +    { "out_color_matrix", "set output YCbCr type",  OFFSET(out_color_matrix), AV_OPT_TYPE_INT, { .i64 = AVCOL_SPC_UNSPECIFIED }, 0, AVCOL_SPC_NB-1, .flags = FLAGS, "color"},

Bug: Should be set to -1 by default, to preserve old behavior. Will fix
in v2.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-10-28 13:31 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-27 17:04 [FFmpeg-devel] [PATCH 1/8] swscale: fix sws_setColorspaceDetails after sws_init_context Niklas Haas
2023-10-27 17:04 ` [FFmpeg-devel] [PATCH 2/8] avfilter/vf_extractplanes: tag alpha plane as full range Niklas Haas
2023-10-28  2:02   ` Vittorio Giovara
2023-10-27 17:04 ` [FFmpeg-devel] [PATCH 3/8] avfilter/vf_alphamerge: warn if input not " Niklas Haas
2023-10-27 21:29   ` Michael Niedermayer
2023-10-27 17:04 ` [FFmpeg-devel] [PATCH 4/8] avfilter/vf_scale: properly respect to input colorimetry Niklas Haas
2023-10-27 21:01   ` Michael Niedermayer
2023-10-28 10:50     ` Niklas Haas
2023-10-28 11:18       ` Niklas Haas
2023-10-27 17:04 ` [FFmpeg-devel] [PATCH 5/8] avfilter/vf_scale: preserve YUV range by default Niklas Haas
2023-10-27 17:04 ` [FFmpeg-devel] [PATCH 6/8] avfilter/vf_scale: simplify color matrix parsing logic Niklas Haas
2023-10-28 13:31   ` Niklas Haas [this message]
2023-10-27 17:04 ` [FFmpeg-devel] [PATCH 7/8] avfilter/vf_scale: tag output color space Niklas Haas
2023-10-28  2:04   ` Vittorio Giovara
2023-10-27 17:04 ` [FFmpeg-devel] [PATCH 8/8] avcodec/pnm: explicitly tag color range Niklas Haas
2023-10-27 18:34   ` Vittorio Giovara
2023-10-27 21:42 ` [FFmpeg-devel] [PATCH 1/8] swscale: fix sws_setColorspaceDetails after sws_init_context Michael Niedermayer
2023-10-28 10:46   ` Niklas Haas
2023-10-28 21:53     ` Michael Niedermayer
2023-10-28 14:38   ` Niklas Haas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231028153132.GB43691@haasn.xyz \
    --to=ffmpeg@haasn.xyz \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=git@haasn.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git