From: Niklas Haas <ffmpeg@haasn.xyz>
To: ffmpeg-devel@ffmpeg.org
Cc: Niklas Haas <git@haasn.dev>
Subject: [FFmpeg-devel] [PATCH v2 07/10] avfilter/vf_scale: preserve YUV range by default
Date: Sat, 28 Oct 2023 16:41:14 +0200
Message-ID: <20231028144430.60538-8-ffmpeg@haasn.xyz> (raw)
In-Reply-To: <20231028144430.60538-1-ffmpeg@haasn.xyz>
From: Niklas Haas <git@haasn.dev>
YUV->YUV conversions should preserve input range, if the output range is
unspecified. Ensures full-range YUV input comes out as full-range YUV
output by default, even through YUV->YUV pixel format conversions.
---
libavfilter/vf_scale.c | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c
index 3d58de0494..cde6f52169 100644
--- a/libavfilter/vf_scale.c
+++ b/libavfilter/vf_scale.c
@@ -687,6 +687,27 @@ static int scale_field(ScaleContext *scale, AVFrame *dst, AVFrame *src,
return 0;
}
+static int is_regular_yuv(enum AVPixelFormat fmt)
+{
+ const AVPixFmtDescriptor *desc = av_pix_fmt_desc_get(fmt);
+ if (desc->flags & (AV_PIX_FMT_FLAG_RGB | AV_PIX_FMT_FLAG_PAL))
+ return 0;
+ if (desc->name && av_strstart(desc->name, "xyz", NULL))
+ return 0;
+ if (desc->nb_components < 3)
+ return 0; /* grayscale is forced full range inside libswscale */
+ switch (fmt) {
+ case AV_PIX_FMT_YUVJ420P:
+ case AV_PIX_FMT_YUVJ422P:
+ case AV_PIX_FMT_YUVJ444P:
+ case AV_PIX_FMT_YUVJ440P:
+ case AV_PIX_FMT_YUVJ411P:
+ return 0;
+ default:
+ return 1;
+ }
+}
+
static int scale_frame(AVFilterLink *link, AVFrame *in, AVFrame **frame_out)
{
AVFilterContext *ctx = link->dst;
@@ -794,6 +815,8 @@ scale:
in_full = in->color_range == AVCOL_RANGE_JPEG;
if (scale->out_range != AVCOL_RANGE_UNSPECIFIED)
out_full = scale->out_range == AVCOL_RANGE_JPEG;
+ else if (is_regular_yuv(in->format) && is_regular_yuv(outlink->format))
+ out_full = in_full; /* preserve pixel range by default */
if (in->width == outlink->w &&
in->height == outlink->h &&
--
2.42.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-10-28 14:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-28 14:41 [FFmpeg-devel] [PATCH v2 00/10] YUVJ removal preliminary cleanup Niklas Haas
2023-10-28 14:41 ` [FFmpeg-devel] [PATCH v2 01/10] swscale: fix sws_setColorspaceDetails after sws_init_context Niklas Haas
2023-10-28 14:41 ` [FFmpeg-devel] [PATCH v2 02/10] swscale: don't omit ff_sws_init_range_convert for high-bit Niklas Haas
2023-10-28 14:41 ` [FFmpeg-devel] [PATCH v2 03/10] swscale/yuv2rgb: fix sws_getCoefficients for colorspace=0 Niklas Haas
2023-10-28 14:41 ` [FFmpeg-devel] [PATCH v2 04/10] avfilter/vf_extractplanes: tag alpha plane as full range Niklas Haas
2023-10-28 14:41 ` [FFmpeg-devel] [PATCH v2 05/10] avfilter/vf_alphamerge: warn if input not " Niklas Haas
2023-10-28 14:41 ` [FFmpeg-devel] [PATCH v2 06/10] avfilter/vf_scale: properly respect to input colorimetry Niklas Haas
2023-10-31 12:18 ` Niklas Haas
2023-10-28 14:41 ` Niklas Haas [this message]
2023-10-30 23:42 ` [FFmpeg-devel] [PATCH v2 07/10] avfilter/vf_scale: preserve YUV range by default Michael Niedermayer
2023-10-31 11:23 ` Niklas Haas
2023-10-28 14:41 ` [FFmpeg-devel] [PATCH v2 08/10] avfilter/vf_scale: simplify color matrix parsing logic Niklas Haas
2023-10-28 14:41 ` [FFmpeg-devel] [PATCH v2 09/10] avfilter/vf_scale: tag output color space Niklas Haas
2023-10-28 14:41 ` [FFmpeg-devel] [PATCH v2 10/10] avcodec/pnm: explicitly tag color range Niklas Haas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231028144430.60538-8-ffmpeg@haasn.xyz \
--to=ffmpeg@haasn.xyz \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=git@haasn.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git