From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D96A247870 for ; Thu, 26 Oct 2023 19:56:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 232ED68CAD6; Thu, 26 Oct 2023 22:56:52 +0300 (EEST) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A986868C63A for ; Thu, 26 Oct 2023 22:56:45 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 09CE2FF80F for ; Thu, 26 Oct 2023 19:56:44 +0000 (UTC) Date: Thu, 26 Oct 2023 21:56:44 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20231026195644.GK3543730@pb2> References: <20231004225921.30287-1-michael@niedermayer.cc> <68f28bbf1c99382c3015efe8eb09b416f2b8ed8d.camel@haerdin.se> MIME-Version: 1.0 In-Reply-To: <68f28bbf1c99382c3015efe8eb09b416f2b8ed8d.camel@haerdin.se> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 1/4] avcodec/jpeg2000dec: Check image offset X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3025612409370590583==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3025612409370590583== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="swnKLXWA95G0aPvL" Content-Disposition: inline --swnKLXWA95G0aPvL Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 25, 2023 at 09:20:09PM +0200, Tomas H=E4rdin wrote: > On Thu, 2023-10-05 at 00:59 +0200, Michael Niedermayer wrote: > > Fixes: left shift of negative value -538967841 > > Fixes: 62447/clusterfuzz-testcase-minimized- > > ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-6427134337613824 > >=20 > > Found-by: continuous fuzzing process > > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > > Signed-off-by: Michael Niedermayer > > --- > > =A0libavcodec/jpeg2000dec.c | 5 +++++ > > =A01 file changed, 5 insertions(+) > >=20 > > diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/jpeg2000dec.c > > index eda959e558d..691cfbd8915 100644 > > --- a/libavcodec/jpeg2000dec.c > > +++ b/libavcodec/jpeg2000dec.c > > @@ -238,6 +238,11 @@ static int get_siz(Jpeg2000DecoderContext *s) > > =A0=A0=A0=A0=A0=A0=A0=A0 return AVERROR_INVALIDDATA; > > =A0=A0=A0=A0 } > > =A0 > > +=A0=A0=A0 if (s->image_offset_x >=3D s->width || s->image_offset_y >= =3D s- > > >height) { > > +=A0=A0=A0=A0=A0=A0=A0 av_log(s->avctx, AV_LOG_ERROR, "image offsets ou= tside > > image"); > > +=A0=A0=A0=A0=A0=A0=A0 return AVERROR_INVALIDDATA; > > +=A0=A0=A0 } >=20 > Probably OK will apply thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Republics decline into democracies and democracies degenerate into despotisms. -- Aristotle --swnKLXWA95G0aPvL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZTrEdwAKCRBhHseHBAsP q21PAKCYQ5/fKBsNY0xzOsLl+Kx4UeBw/wCeOXasg5kVYF2R27TVpDiz9ZJqaCA= =kFAh -----END PGP SIGNATURE----- --swnKLXWA95G0aPvL-- --===============3025612409370590583== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3025612409370590583==--