From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A249A47D9A for ; Thu, 26 Oct 2023 14:05:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BD4CD68CB09; Thu, 26 Oct 2023 17:05:12 +0300 (EEST) Received: from haasn.dev (haasn.dev [78.46.187.166]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2A40068C94E for ; Thu, 26 Oct 2023 17:05:06 +0300 (EEST) Received: from haasn.dev (unknown [10.30.0.2]) by haasn.dev (Postfix) with ESMTP id D0E5A49516 for ; Thu, 26 Oct 2023 16:05:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=haasn.xyz; s=mail; t=1698329105; bh=dB3lf1vs3HIEAWTBJcxU8tsdgt8bKgvlgrTYILThYD4=; h=Date:From:To:Subject:In-Reply-To:References:From; b=Ky51CQXnd4pI5UzLfnrDY72WQhzABtufcrp7HmeD7PQW7pqkYEd1kcI8qyFBbexsC zrzXuakrHxQP/h29XIvl0vqImaNPGo2gYN8fwR6RW0MEVybfSu/5OJB1GWTTCj8n5r ZrtHf6KFpDUNTQCpQ3nqsa9iXvaPLeHWP1c+Y4yk= Date: Thu, 26 Oct 2023 16:05:05 +0200 Message-ID: <20231026160505.GB3605@haasn.xyz> From: Niklas Haas To: ffmpeg-devel@ffmpeg.org In-Reply-To: <7f7bb9ee-54f5-4c59-9aff-7bbc29a1de72@gmail.com> References: <20231026121901.68926-1-ffmpeg@haasn.xyz> <20231026121901.68926-3-ffmpeg@haasn.xyz> <7f7bb9ee-54f5-4c59-9aff-7bbc29a1de72@gmail.com> MIME-Version: 1.0 Content-Disposition: inline Subject: Re: [FFmpeg-devel] [PATCH 3/5] avfilter/drawutils: simplify xyz format check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 26 Oct 2023 10:13:03 -0300 James Almer wrote: > On 10/26/2023 9:23 AM, Nicolas George wrote: > > Niklas Haas (12023-10-26): > >> From: Niklas Haas > >> > >> --- > >> libavfilter/drawutils.c | 3 --- > >> 1 file changed, 3 deletions(-) > > > > Please merge this with patch 1. > > This patch reverts patch 1, so merging is basically just dropping both. > I assume the reason he did things this way is to prevent patch 2 (an > avutil patch adding new API) from changing the output filter-pixfmts-pad. Yes, exactly. But if you want, I can merge the FATE ref change into patch 2. I just thought this way separates the logic change (bugfix in drawutils) from the new API addition, which is IMO cleaner. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".