From: Niklas Haas <ffmpeg@haasn.xyz>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 3/5] avfilter/drawutils: simplify xyz format check
Date: Thu, 26 Oct 2023 16:05:05 +0200
Message-ID: <20231026160505.GB3605@haasn.xyz> (raw)
In-Reply-To: <7f7bb9ee-54f5-4c59-9aff-7bbc29a1de72@gmail.com>
On Thu, 26 Oct 2023 10:13:03 -0300 James Almer <jamrial@gmail.com> wrote:
> On 10/26/2023 9:23 AM, Nicolas George wrote:
> > Niklas Haas (12023-10-26):
> >> From: Niklas Haas <git@haasn.dev>
> >>
> >> ---
> >> libavfilter/drawutils.c | 3 ---
> >> 1 file changed, 3 deletions(-)
> >
> > Please merge this with patch 1.
>
> This patch reverts patch 1, so merging is basically just dropping both.
> I assume the reason he did things this way is to prevent patch 2 (an
> avutil patch adding new API) from changing the output filter-pixfmts-pad.
Yes, exactly. But if you want, I can merge the FATE ref change into
patch 2. I just thought this way separates the logic change (bugfix in
drawutils) from the new API addition, which is IMO cleaner.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-10-26 14:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 12:18 [FFmpeg-devel] [PATCH 1/5] avfilter/drawutils: ban XYZ formats Niklas Haas
2023-10-26 12:18 ` [FFmpeg-devel] [PATCH 2/5] avutil/pixdesc: add AV_PIX_FMT_FLAG_XYZ Niklas Haas
2023-10-26 12:18 ` [FFmpeg-devel] [PATCH 3/5] avfilter/drawutils: simplify xyz format check Niklas Haas
2023-10-26 12:23 ` Nicolas George
2023-10-26 13:13 ` James Almer
2023-10-26 13:30 ` Nicolas George
2023-10-26 14:05 ` Niklas Haas [this message]
2023-10-26 14:13 ` epirat07
2023-10-26 12:19 ` [FFmpeg-devel] [PATCH 4/5] avutil/pixdesc: simplify xyz pixfmt check Niklas Haas
2023-10-26 12:19 ` [FFmpeg-devel] [PATCH 5/5] avformat/vf_vapoursynth: simplify xyz format check Niklas Haas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231026160505.GB3605@haasn.xyz \
--to=ffmpeg@haasn.xyz \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git