From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C0FDD476E5 for ; Fri, 20 Oct 2023 14:11:46 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 061CF68C9F3; Fri, 20 Oct 2023 17:11:44 +0300 (EEST) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B928E68C63A for ; Fri, 20 Oct 2023 17:11:36 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id EA874E000C for ; Fri, 20 Oct 2023 14:11:35 +0000 (UTC) Date: Fri, 20 Oct 2023 16:11:35 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20231020141135.GQ3543730@pb2> References: <20231013142706.23971-1-ffmpeg@haasn.xyz> <20231013142706.23971-3-ffmpeg@haasn.xyz> <20231014134634.GC89414@haasn.xyz> <169781005673.30698.11519230045707447960@lain.khirnov.net> MIME-Version: 1.0 In-Reply-To: <169781005673.30698.11519230045707447960@lain.khirnov.net> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH v2 02/13] avcodec: add extended AVCodec color metadata X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2537837506562634642==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2537837506562634642== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zCCxS6ko+H2ridsi" Content-Disposition: inline --zCCxS6ko+H2ridsi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 20, 2023 at 03:54:16PM +0200, Anton Khirnov wrote: > Quoting Niklas Haas (2023-10-14 13:46:34) > > > 3. I don't see how the MJPEG encoder behaviour where the valid formats > > > de facto depend upon strictness can be encoded in this way; isn't the > > > aim to get rid of the necessity of the workaround in ffmpeg cli? > >=20 > > Note that ffmpeg cli presently initializes the filter graph well before > > the AVCodecContext is set up with options, let alone opened. (Presently, > > the logic for overriding the pixfmt list directly looks up the "strict" > > field in the options dict) > >=20 > > So that limits the design space somewhat for elegant solutions here. > > Either we make the "return list of supported formats" callback in > > AVCodec simply accept the strict_std_compliance setting directly, or we > > extend the static list of colorspaces itself by an extra strictness > > field. Probably the former is better than the latter of these two > > approaches. >=20 > FWIW I find that behaviour to be a disgusting hack and the cleanest way > to address it would IMO be a separate mjpeg_experimental AVCodec > instance. That is assuming anyone actually needs this functionality. > Maybe we could also just drop it? The usecase i remember was lossless jpeg, but this seems to support it by default now If there is still a usecase, then i agree *jpeg_experimental would be an option. or maybe jpeg_somethingrange maybe this is usefull for encoding some mjpeg variants. Somehow i think they didnt all use the same range thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Elect your leaders based on what they did after the last election, not based on what they say before an election. --zCCxS6ko+H2ridsi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZTKKkwAKCRBhHseHBAsP q7RlAJ4xaxWMr8x4rZye2pN6q/y6UjI4zgCfQO3mFvAwmfKKw18cKlDBTAnnpSE= =cyAz -----END PGP SIGNATURE----- --zCCxS6ko+H2ridsi-- --===============2537837506562634642== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2537837506562634642==--