From: Niklas Haas <ffmpeg@haasn.xyz>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2 00/13] YUVJ removal
Date: Fri, 20 Oct 2023 13:30:37 +0200
Message-ID: <20231020133037.GB20299@haasn.xyz> (raw)
In-Reply-To: <CABLWnS8WJvLK8-KecW_SeyPJ2crCfDkgdtuOBf7_OG++_ApViw@mail.gmail.com>
On Fri, 13 Oct 2023 14:33:11 -0400 Vittorio Giovara <vittorio.giovara@gmail.com> wrote:
> On Fri, Oct 13, 2023 at 10:27 AM Niklas Haas <ffmpeg@haasn.xyz> wrote:
>
> > Changes since v1:
> >
> > - Remove unneeded patch (AVCodecContext.colorspace init)
> > - Merge auto-range conversion into auto-scale filter
> > - Replace vf_zscale by vf_colorspace in fftools
> >
>
> Why is this? I haven't checked what vf_colorspace supports in a hot second,
> but iirc zscale can handle non linear spaces better and hdr conversion
> If it's because it's a built in filter, do you think we could first check
> for zscale presence and fallback to colorspace?
>
> - Add some miscellaneous fixes for various FATE tests
> > - Clean up some additional vestigiaul YUVJ remnants
> >
N.B.: Another issue with vf_scale/vf_colorspace is that vf_scale
currently doesn't handle colorspace metadata at all, which is blocking
the ability to add this (easily) to filter negotiation, since filter
negotiation hard-codes the "scale" filter for auto-converting between
any mismatch.
I am considering even just dropping the extended colorspace metadata
(primaries, trc) from this series completely, or at least splitting them
into separate patchsets. One to only remove YUVJ and add the color range
+ filter negotiation, and one to add all of the remaining colorspace
metadata.
Then the bikeshed about how to convert between these remaining bits of
metadata can be left to that series, and not block YUVJ removal.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-10-20 11:30 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 14:24 Niklas Haas
2023-10-13 14:24 ` [FFmpeg-devel] [PATCH v2 01/13] avfilter/vf_scale: don't change range by default Niklas Haas
2023-10-13 14:24 ` [FFmpeg-devel] [PATCH v2 02/13] avcodec: add extended AVCodec color metadata Niklas Haas
2023-10-13 17:10 ` Andreas Rheinhardt
2023-10-13 18:52 ` Vittorio Giovara
2023-10-14 10:29 ` Niklas Haas
2023-10-14 11:46 ` Niklas Haas
2023-10-20 13:54 ` Anton Khirnov
2023-10-20 14:11 ` Michael Niedermayer
2023-10-20 14:01 ` Anton Khirnov
2023-10-14 13:31 ` Leo Izen
2023-10-14 13:40 ` Niklas Haas
2023-10-13 14:24 ` [FFmpeg-devel] [PATCH v2 03/13] fftools/ffmpeg_filter: auto-convert range if needed Niklas Haas
2023-10-13 14:24 ` [FFmpeg-devel] [PATCH v2 04/13] lavfi/vf_colorspace: support prim/trc/csp passthrough Niklas Haas
2023-10-13 14:24 ` [FFmpeg-devel] [PATCH v2 05/13] fftools/ffmpeg_filter: auto-insert colorspace filter Niklas Haas
2023-10-13 14:24 ` [FFmpeg-devel] [PATCH v2 06/13] avcodec/encode: enforce AVCodec capabilities at encode time Niklas Haas
2023-10-13 14:24 ` [FFmpeg-devel] [PATCH v2 07/13] tests/fate: force MPEG range for rawvideo tests Niklas Haas
2023-10-13 14:24 ` [FFmpeg-devel] [PATCH v2 08/13] tests/fate: allow conversion filters in jpg-icc test Niklas Haas
2023-10-13 14:24 ` [FFmpeg-devel] [PATCH v2 09/13] lavc: set color_ranges for YUVJ-only codecs Niklas Haas
2023-10-13 14:24 ` [FFmpeg-devel] [PATCH v2 10/13] lavfi/lavu/lavc: remove YUVJ pixel formats Niklas Haas
2023-10-13 14:24 ` [FFmpeg-devel] [PATCH v2 11/13] swscale/utils: simplify JPEG handling function Niklas Haas
2023-10-13 14:24 ` [FFmpeg-devel] [PATCH v2 12/13] tests/fate: remove unused YUVJ ref files Niklas Haas
2023-10-13 14:24 ` [FFmpeg-devel] [PATCH v2 13/13] avutil/pixdesc: remove old yuvj pixel format check Niklas Haas
2023-10-13 18:33 ` [FFmpeg-devel] [PATCH v2 00/13] YUVJ removal Vittorio Giovara
2023-10-13 21:14 ` Lynne
2023-10-13 22:21 ` Vittorio Giovara
2023-10-14 13:11 ` Lynne
2023-10-14 15:15 ` Vittorio Giovara
2023-10-14 15:18 ` Lynne
2023-10-20 12:14 ` Ronald S. Bultje
2023-10-20 16:14 ` Vittorio Giovara
2023-10-20 23:13 ` Ronald S. Bultje
2023-10-21 23:20 ` Michael Niedermayer
2023-10-24 0:56 ` Vittorio Giovara
2023-10-25 22:15 ` Michael Niedermayer
2023-10-20 11:30 ` Niklas Haas [this message]
2023-10-20 16:17 ` Vittorio Giovara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231020133037.GB20299@haasn.xyz \
--to=ffmpeg@haasn.xyz \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git