From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EC44C46578 for ; Thu, 19 Oct 2023 18:53:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DCB2968CA95; Thu, 19 Oct 2023 21:53:13 +0300 (EEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4C25068CA95 for ; Thu, 19 Oct 2023 21:53:07 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 942EB60002 for ; Thu, 19 Oct 2023 18:53:06 +0000 (UTC) Date: Thu, 19 Oct 2023 20:53:05 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20231019185305.GO3543730@pb2> References: <20231015001323.1073-1-michael@niedermayer.cc> <169771381849.29037.11341794027795365044@lain.khirnov.net> <20231019163313.GH3543730@pb2> <169773735094.30698.2006289459200607623@lain.khirnov.net> MIME-Version: 1.0 In-Reply-To: <169773735094.30698.2006289459200607623@lain.khirnov.net> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov: The iloc test is not redundant X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5775537222620833149==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5775537222620833149== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VqvGADyZOcySACrJ" Content-Disposition: inline --VqvGADyZOcySACrJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 19, 2023 at 07:42:30PM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2023-10-19 18:33:13) > > On Thu, Oct 19, 2023 at 01:10:18PM +0200, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2023-10-15 02:13:23) > > > > Fixes: Assertion failure > > > > Fixes: 62866/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-5= 282997370486784 > > > >=20 > > > > Found-by: continuous fuzzing process https://github.com/google/oss-= fuzz/tree/master/projects/ffmpeg > > > > Signed-off-by: Michael Niedermayer > > > > --- > > >=20 > > > The commit message is useless. > >=20 > > This comment is also not that usefull > > What would you like to see in the commit message ? > >=20 > > The 2 checks are not redundant. Should the message detail how > > the assertion failure occured ? >=20 > At least two people previously thought that the condition is redundant, > so it seems clear to me that an explanation is in order. >=20 > I actually find it quite baffling that this is not obvious to you. Do > you really think that "Fixes: Assertion failure" is sufficient > explanation for anyone reading this patch? let me ask this from the other direction (and i should probably have done so sooner) why would this be redundant ? the failed check checks the number of streams, why should a random atom not occur after x streams for thf irst time ? what code was supposed to prevent this ? thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If you think the mosad wants you dead since a long time then you are either wrong or dead since a long time. --VqvGADyZOcySACrJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZTF7DgAKCRBhHseHBAsP q0lWAJ4nyUC/7piHGNmyxr7ouc+WbPe5TgCfXLg/fjJnTwdR3uxo/V240dzSg3c= =EihZ -----END PGP SIGNATURE----- --VqvGADyZOcySACrJ-- --===============5775537222620833149== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5775537222620833149==--