Re: [FFmpeg-devel] [PATCH] avformat/mov: The iloc test is not redundant

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1651 bytes --]

On Thu, Oct 19, 2023 at 07:42:30PM +0200, Anton Khirnov wrote:
> Quoting Michael Niedermayer (2023-10-19 18:33:13)
> > On Thu, Oct 19, 2023 at 01:10:18PM +0200, Anton Khirnov wrote:
> > > Quoting Michael Niedermayer (2023-10-15 02:13:23)
> > > > Fixes: Assertion failure
> > > > Fixes: 62866/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-5282997370486784
> > > > 
> > > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> > > > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > > > ---
> > > 
> > > The commit message is useless.
> > 
> > This comment is also not that usefull
> > What would you like to see in the commit message ?
> > 
> > The 2 checks are not redundant. Should the message detail how
> > the assertion failure occured ?
> 
> At least two people previously thought that the condition is redundant,
> so it seems clear to me that an explanation is in order.
> 
> I actually find it quite baffling that this is not obvious to you. Do
> you really think that "Fixes: Assertion failure" is sufficient
> explanation for anyone reading this patch?

let me ask this from the other direction (and i should probably have done
so sooner)

why would this be redundant ?

the failed check checks the number of streams, why should a random atom
not occur after x streams for thf irst time ?
what code was supposed to prevent this ?

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you think the mosad wants you dead since a long time then you are either
wrong or dead since a long time.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".