From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9C56447D2E for ; Thu, 19 Oct 2023 16:33:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3609968CAFD; Thu, 19 Oct 2023 19:33:22 +0300 (EEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BE4AE68C63A for ; Thu, 19 Oct 2023 19:33:15 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 8D6E960006 for ; Thu, 19 Oct 2023 16:33:14 +0000 (UTC) Date: Thu, 19 Oct 2023 18:33:13 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20231019163313.GH3543730@pb2> References: <20231015001323.1073-1-michael@niedermayer.cc> <169771381849.29037.11341794027795365044@lain.khirnov.net> MIME-Version: 1.0 In-Reply-To: <169771381849.29037.11341794027795365044@lain.khirnov.net> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov: The iloc test is not redundant X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5126286995789516092==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5126286995789516092== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lTbjHS9ResYW5N/f" Content-Disposition: inline --lTbjHS9ResYW5N/f Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 19, 2023 at 01:10:18PM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2023-10-15 02:13:23) > > Fixes: Assertion failure > > Fixes: 62866/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-52829= 97370486784 > >=20 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz= /tree/master/projects/ffmpeg > > Signed-off-by: Michael Niedermayer > > --- >=20 > The commit message is useless. This comment is also not that usefull What would you like to see in the commit message ? The 2 checks are not redundant. Should the message detail how the assertion failure occured ? Would you prefer if the 2nd condition produces an error instead of return 0= ? Is there something else ? thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The smallest minority on earth is the individual. Those who deny=20 individual rights cannot claim to be defenders of minorities. - Ayn Rand --lTbjHS9ResYW5N/f Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZTFaRgAKCRBhHseHBAsP q2HcAJwKej/Ni+bWOUnlRsFD2X6aTlzE8QCfQLhRE37FMKDjJEkMCkUhIbxzkwg= =u9sW -----END PGP SIGNATURE----- --lTbjHS9ResYW5N/f-- --===============5126286995789516092== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5126286995789516092==--