From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E51C447D26 for ; Thu, 19 Oct 2023 11:43:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0C57268CB08; Thu, 19 Oct 2023 14:43:51 +0300 (EEST) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5E70068C9F8 for ; Thu, 19 Oct 2023 14:43:45 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 8F202C0004 for ; Thu, 19 Oct 2023 11:43:44 +0000 (UTC) Date: Thu, 19 Oct 2023 13:43:43 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20231019114343.GG3543730@pb2> References: <20231015032724.3590-1-gseanmcg@gmail.com> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] libavutil/ppc/cpu.c: check that AT_HWCAP2 is defined X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8145334273596586765==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8145334273596586765== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="y+KtxNjwEe4Q3Zyh" Content-Disposition: inline --y+KtxNjwEe4Q3Zyh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 18, 2023 at 01:18:54PM -0400, Sean McGovern wrote: > On Sat, Oct 14, 2023, 23:27 Sean McGovern wrote: >=20 > > It was not introduced until glibc 2.18. > > --- > > This should fix the ppc32 FATE node. > > --- > > libavutil/ppc/cpu.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/libavutil/ppc/cpu.c b/libavutil/ppc/cpu.c > > index 96b491c716..bc8bb5f47c 100644 > > --- a/libavutil/ppc/cpu.c > > +++ b/libavutil/ppc/cpu.c > > @@ -95,12 +95,15 @@ int ff_get_cpu_flags_ppc(void) > > #endif > > if (ret & AV_CPU_FLAG_VSX) > > av_assert0(ret & AV_CPU_FLAG_ALTIVEC); > > - } else if (buf[i] =3D=3D AT_HWCAP2) { > > + } > > +#ifdef AT_HWCAP2 /* not introduced until glibc 2.18 */ > > + else if (buf[i] =3D=3D AT_HWCAP2) { > > #ifdef PPC_FEATURE2_ARCH_2_07 > > if (buf[i + 1] & PPC_FEATURE2_ARCH_2_07) > > ret |=3D AV_CPU_FLAG_POWER8; > > #endif > > } > > +#endif /* AT_HWCAP2 */ > > } > > } > > > > -- > > 2.39.2 > > >=20 > Ping review. will apply with my next push to master >=20 > Alternatively, can the ppc32 FATE nodes be upgraded to a distribution > release with glibc 2.18 or higher? > Can I assist with that somehow? If you want, you can run a fate client to replace or augment the old one. for this sent the public ssh key the cleint will use to fate-admin (email a= ddr should be in the docs) thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If you fake or manipulate statistics in a paper in physics you will never get a job again. If you fake or manipulate statistics in a paper in medicin you will get a job for life at the pharma industry. --y+KtxNjwEe4Q3Zyh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZTEWbAAKCRBhHseHBAsP q/nhAJ0SNxPpru3ZP8J7nYVYL61WjqbzAACeLFFHZLDsiy5s56Y86WNg6d32O9I= =m2Ph -----END PGP SIGNATURE----- --y+KtxNjwEe4Q3Zyh-- --===============8145334273596586765== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8145334273596586765==--