From: TADANO Tokumei <aimingoff@pc.nifty.jp> To: ffmpeg-devel@ffmpeg.org Cc: TADANO Tokumei <aimingoff@pc.nifty.jp> Subject: [FFmpeg-devel] [PATCH v3 1/3] lavc/libaribcaption.c: FIX: change all `boot` option var to `int` Date: Tue, 17 Oct 2023 20:21:57 +0900 Message-ID: <20231017112159.199755-2-aimingoff@pc.nifty.jp> (raw) In-Reply-To: <20230923020023.9288-1-aimingoff@pc.nifty.jp> This patch fixes a bug in curret version. On some environments, a `bool` variable is small space than `int`. If a `bool` option was specified by command line, following variables would be filled and may be destroyed by av_opt_copy(). This patch change all the `bool` option variables in `ARIBCaptionContext` to `int`. Signed-off-by: TADANO Tokumei <aimingoff@pc.nifty.jp> --- libavcodec/libaribcaption.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/libaribcaption.c b/libavcodec/libaribcaption.c index 8a8c8f8cfd..be3328c5c9 100644 --- a/libavcodec/libaribcaption.c +++ b/libavcodec/libaribcaption.c @@ -68,14 +68,14 @@ typedef struct ARIBCaptionContext { int subtitle_type; int encoding_scheme; - bool ass_single_rect; + int ass_single_rect; char *font; - bool replace_fullwidth_ascii; - bool force_stroke_text; - bool ignore_background; - bool ignore_ruby; + int replace_fullwidth_ascii; + int force_stroke_text; + int ignore_background; + int ignore_ruby; float stroke_width; - bool replace_drcs; + int replace_drcs; int64_t pts; AVRational time_base; -- 2.39.2 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-10-17 11:22 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-09-23 2:00 [FFmpeg-devel] [PATCH v2] lavc/libaribcaption.c: add MSZ characters related options TADANO Tokumei 2023-09-23 2:15 ` TADANO Tokumei 2023-09-29 10:31 ` TADANO Tokumei 2023-10-10 10:28 ` TADANO Tokumei 2023-10-11 21:32 ` Jan Ekström 2023-10-17 11:21 ` [FFmpeg-devel] [PATCH v3 0/3] " TADANO Tokumei 2023-10-17 11:21 ` TADANO Tokumei [this message] 2023-10-17 11:21 ` [FFmpeg-devel] [PATCH v3 2/3] " TADANO Tokumei 2023-10-17 11:21 ` [FFmpeg-devel] [PATCH v3 3/3] lavc/libaribcaption.c: rename `-replace_fullwidth_ascii` option TADANO Tokumei
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20231017112159.199755-2-aimingoff@pc.nifty.jp \ --to=aimingoff@pc.nifty.jp \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git