From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EF1E547645 for ; Sun, 15 Oct 2023 17:15:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CB7BE68C69A; Sun, 15 Oct 2023 20:15:24 +0300 (EEST) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E563068C3CB for ; Sun, 15 Oct 2023 20:15:17 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 3983C20007 for ; Sun, 15 Oct 2023 17:15:16 +0000 (UTC) Date: Sun, 15 Oct 2023 19:15:16 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20231015171516.GY3543730@pb2> References: <20231014172428.382368-1-stefasab@gmail.com> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] ffprobe: fix XML rendering, review XML layout X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1141238262511485299==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1141238262511485299== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iz7pcATjcRly4pHm" Content-Disposition: inline --iz7pcATjcRly4pHm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 14, 2023 at 09:50:24PM +0200, Stefano Sabatini wrote: > On date Saturday 2023-10-14 19:24:28 +0200, Stefano Sabatini wrote: > > Fix rendering of int values within a side data element, which was > > broken since commit d2d3a83ad93, where the side data element was > > correctly marked as a variable fields element. Logic to render a > > string variable was implemented already, but it was not implemented > > for the int fields path, which was enabled by that commit. > [...] >=20 > V2 with schema fixes. >=20 > I'd like to include the fixed version with 6.1 (will probably push in > a few days if I see no comments). > Changelog | 2 + > doc/ffprobe.xsd | 31 +++++++++++++++++++++------- > fftools/ffprobe.c | 49 +++++++++++++++++++++++++++++++++-----= ------- > tests/ref/fate/ffprobe_xml | 26 +++++++++++++++-------- This needs to update fate references one example: diff --git a/tests/ref/fate/flv-demux b/tests/ref/fate/flv-demux index 0a00276276..b40ca639a2 100644 --- a/tests/ref/fate/flv-demux +++ b/tests/ref/fate/flv-demux @@ -1,5 +1,5 @@ -packet|codec_type=3Daudio|stream_index=3D1|pts=3D0|pts_time=3D0.000000|dts= =3D0|dts_time=3D0.000000|duration=3D46|duration_time=3D0.046000|size=3D9|po= s=3D3241|flags=3DK__|data_hash=3DCRC32:bbb61b93|side_data/new_extradata:sid= e_data_type=3DNew Extradata -packet|codec_type=3Dvideo|stream_index=3D0|pts=3D0|pts_time=3D0.000000|dts= =3D0|dts_time=3D0.000000|duration=3D33|duration_time=3D0.033000|size=3D135|= pos=3D3267|flags=3DK__|data_hash=3DCRC32:3f2ccc9e|side_data/new_extradata:s= ide_data_type=3DNew Extradata +packet|codec_type=3Daudio|stream_index=3D1|pts=3D0|pts_time=3D0.000000|dts= =3D0|dts_time=3D0.000000|duration=3D46|duration_time=3D0.046000|size=3D9|po= s=3D3241|flags=3DK__|data_hash=3DCRC32:bbb61b93|side_datum/new_extradata:si= de_data_type=3DNew Extradata +packet|codec_type=3Dvideo|stream_index=3D0|pts=3D0|pts_time=3D0.000000|dts= =3D0|dts_time=3D0.000000|duration=3D33|duration_time=3D0.033000|size=3D135|= pos=3D3267|flags=3DK__|data_hash=3DCRC32:3f2ccc9e|side_datum/new_extradata:= side_data_type=3DNew Extradata packet|codec_type=3Dvideo|stream_index=3D0|pts=3D33|pts_time=3D0.033000|dt= s=3D33|dts_time=3D0.033000|duration=3D33|duration_time=3D0.033000|size=3D92= |pos=3D3422|flags=3D___|data_hash=3DCRC32:c14e72b2 packet|codec_type=3Daudio|stream_index=3D1|pts=3D46|pts_time=3D0.046000|dt= s=3D46|dts_time=3D0.046000|duration=3D46|duration_time=3D0.046000|size=3D9|= pos=3D3534|flags=3DK__|data_hash=3DCRC32:bbb61b93 packet|codec_type=3Dvideo|stream_index=3D0|pts=3D67|pts_time=3D0.067000|dt= s=3D67|dts_time=3D0.067000|duration=3D33|duration_time=3D0.033000|size=3D14= |pos=3D3560|flags=3D___|data_hash=3DCRC32:0b3c3ab4 thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Nations do behave wisely once they have exhausted all other alternatives.= =20 -- Abba Eban --iz7pcATjcRly4pHm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZSweIAAKCRBhHseHBAsP q0B7AJ4qZXOSLByqMj+xsOO1w1kx55NPwACdGTbPGbGzdT81zrROgMOoZ+LHNfg= =qj2b -----END PGP SIGNATURE----- --iz7pcATjcRly4pHm-- --===============1141238262511485299== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1141238262511485299==--