From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 011B547C39 for ; Fri, 13 Oct 2023 22:52:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B590168C795; Sat, 14 Oct 2023 01:52:30 +0300 (EEST) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A6F3168C5D4 for ; Sat, 14 Oct 2023 01:52:24 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id F217140003 for ; Fri, 13 Oct 2023 22:52:23 +0000 (UTC) Date: Sat, 14 Oct 2023 00:52:23 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20231013225223.GS3543730@pb2> References: <20231013142205.60658-1-ffmpeg@haasn.xyz> MIME-Version: 1.0 In-Reply-To: <20231013142205.60658-1-ffmpeg@haasn.xyz> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_scale: fix interlaced chroma for other formats X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8189444602020060999==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8189444602020060999== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8gs9RsbElyYeG6Yn" Content-Disposition: inline --8gs9RsbElyYeG6Yn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 13, 2023 at 04:22:05PM +0200, Niklas Haas wrote: > From: Niklas Haas >=20 > This logic only covers the case of yuv420p. Extend this logic to cover > *all* vertically subsampled YUV formats, which require the same > interlaced scaling logic. >=20 > Fortunately, we can get away with re-using the same code for both JPEG > and MPEG range YUV, because the only difference here is the horizontal > alignment. (To be fixed in a separate commit) > --- > libavfilter/vf_scale.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) the patches from H4JO.txt cause several fate tests to worsen in their stddev. like: --- ./tests/ref/vsynth/vsynth1-mjpeg-huffman 2023-09-29 01:05:25.5349629= 42 +0200 +++ tests/data/fate/vsynth1-mjpeg-huffman 2023-10-13 20:45:05.2286330= 99 +0200 @@ -1,4 +1,4 @@ 63ea9bd494e16bad8f3a0c8dbb3dc11e *tests/data/fate/vsynth1-mjpeg-huffman.avi 1391380 tests/data/fate/vsynth1-mjpeg-huffman.avi -9a3b8169c251d19044f7087a95458c55 *tests/data/fate/vsynth1-mjpeg-huffman.ou= t.rawvideo -stddev: 7.87 PSNR: 30.21 MAXDIFF: 63 bytes: 7603200/ 7603200 +64e440d0421e6b1bf3fbbc539b53e09c *tests/data/fate/vsynth1-mjpeg-huffman.ou= t.rawvideo +stddev: 8.37 PSNR: 29.67 MAXDIFF: 69 bytes: 7603200/ 7603200 This patch in this mail here seems fine thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In a rich man's house there is no place to spit but his face. -- Diogenes of Sinope --8gs9RsbElyYeG6Yn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZSnKIwAKCRBhHseHBAsP q/cSAKCBcmHlXbw2Yqc808/vGjV6FN4TFwCfVVeLm4ezZ1GIbAb2b1NFU3auHvk= =Ac8l -----END PGP SIGNATURE----- --8gs9RsbElyYeG6Yn-- --===============8189444602020060999== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8189444602020060999==--