On Fri, Oct 13, 2023 at 04:22:05PM +0200, Niklas Haas wrote: > From: Niklas Haas > > This logic only covers the case of yuv420p. Extend this logic to cover > *all* vertically subsampled YUV formats, which require the same > interlaced scaling logic. > > Fortunately, we can get away with re-using the same code for both JPEG > and MPEG range YUV, because the only difference here is the horizontal > alignment. (To be fixed in a separate commit) > --- > libavfilter/vf_scale.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) the patches from H4JO.txt cause several fate tests to worsen in their stddev. like: --- ./tests/ref/vsynth/vsynth1-mjpeg-huffman 2023-09-29 01:05:25.534962942 +0200 +++ tests/data/fate/vsynth1-mjpeg-huffman 2023-10-13 20:45:05.228633099 +0200 @@ -1,4 +1,4 @@ 63ea9bd494e16bad8f3a0c8dbb3dc11e *tests/data/fate/vsynth1-mjpeg-huffman.avi 1391380 tests/data/fate/vsynth1-mjpeg-huffman.avi -9a3b8169c251d19044f7087a95458c55 *tests/data/fate/vsynth1-mjpeg-huffman.out.rawvideo -stddev: 7.87 PSNR: 30.21 MAXDIFF: 63 bytes: 7603200/ 7603200 +64e440d0421e6b1bf3fbbc539b53e09c *tests/data/fate/vsynth1-mjpeg-huffman.out.rawvideo +stddev: 8.37 PSNR: 29.67 MAXDIFF: 69 bytes: 7603200/ 7603200 This patch in this mail here seems fine thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In a rich man's house there is no place to spit but his face. -- Diogenes of Sinope