From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6099146D1A for ; Sun, 8 Oct 2023 16:40:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AF53268C9B3; Sun, 8 Oct 2023 19:40:21 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2269D68C709 for ; Sun, 8 Oct 2023 19:40:15 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 66869240002 for ; Sun, 8 Oct 2023 16:40:14 +0000 (UTC) Date: Sun, 8 Oct 2023 18:40:13 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20231008164013.GU3543730@pb2> References: MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 4/7] avcodec/h261dec: Remove pointless goto X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4748796731127766434==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4748796731127766434== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="skgCfLFhCSVZJUH9" Content-Disposition: inline --skgCfLFhCSVZJUH9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 07, 2023 at 02:40:28AM +0200, Andreas Rheinhardt wrote: > There is no need to parse the header twice; doing so does nothing. >=20 > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/h261dec.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/libavcodec/h261dec.c b/libavcodec/h261dec.c > index 91d555a70e..272bbbea34 100644 > --- a/libavcodec/h261dec.c > +++ b/libavcodec/h261dec.c > @@ -605,7 +605,6 @@ static int h261_decode_frame(AVCodecContext *avctx, A= VFrame *pict, > =20 > h->gob_start_code_skipped =3D 0; > =20 > -retry: > init_get_bits(&s->gb, buf, buf_size * 8); > =20 > ret =3D h261_decode_picture_header(h); > @@ -627,8 +626,6 @@ retry: > ret =3D ff_set_dimensions(avctx, s->width, s->height); > if (ret < 0) > return ret; > - > - goto retry; the goto is not pointless, it has a semicolon which includes a point sorry i could not resist [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Whats the most studid thing your enemy could do ? Blow himself up Whats the most studid thing you could do ? Give up your rights and freedom because your enemy blew himself up. --skgCfLFhCSVZJUH9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZSLbbQAKCRBhHseHBAsP q0I0AJ9plVmoLRdLRaL5DHc02G0NIa6jvQCfSNzs3dInDEJZNqiSLG3uWlrHtNg= =9a0B -----END PGP SIGNATURE----- --skgCfLFhCSVZJUH9-- --===============4748796731127766434== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4748796731127766434==--