Re: [FFmpeg-devel] [PATCH 4/7] avcodec/h261dec: Remove pointless goto

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1250 bytes --]

On Sat, Oct 07, 2023 at 02:40:28AM +0200, Andreas Rheinhardt wrote:
> There is no need to parse the header twice; doing so does nothing.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavcodec/h261dec.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/libavcodec/h261dec.c b/libavcodec/h261dec.c
> index 91d555a70e..272bbbea34 100644
> --- a/libavcodec/h261dec.c
> +++ b/libavcodec/h261dec.c
> @@ -605,7 +605,6 @@ static int h261_decode_frame(AVCodecContext *avctx, AVFrame *pict,
>  
>      h->gob_start_code_skipped = 0;
>  
> -retry:
>      init_get_bits(&s->gb, buf, buf_size * 8);
>  
>      ret = h261_decode_picture_header(h);
> @@ -627,8 +626,6 @@ retry:
>          ret = ff_set_dimensions(avctx, s->width, s->height);
>          if (ret < 0)
>              return ret;
> -
> -        goto retry;

the goto is not pointless, it has a semicolon which includes a point

sorry i could not resist


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Whats the most studid thing your enemy could do ? Blow himself up
Whats the most studid thing you could do ? Give up your rights and
freedom because your enemy blew himself up.


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".