From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AF33446D05 for ; Sun, 8 Oct 2023 16:37:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4879268C943; Sun, 8 Oct 2023 19:36:58 +0300 (EEST) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3266768C8B6 for ; Sun, 8 Oct 2023 19:36:51 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 0E0C41BF205 for ; Sun, 8 Oct 2023 16:36:49 +0000 (UTC) Date: Sun, 8 Oct 2023 18:36:48 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20231008163648.GT3543730@pb2> References: MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: Output palette as stream side data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2838629386039922004==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2838629386039922004== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fbglzKaagM3twbm3" Content-Disposition: inline --fbglzKaagM3twbm3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 05, 2023 at 02:36:52PM +0200, Andreas Rheinhardt wrote: > This is simpler implementation-wise (it avoids an almost-always-false > check in read_packet and decreases sizeof(MatroskaTrack) by about 2/3) > and makes the side-data available directly after read_header. >=20 > It also fixes the Matroska analog of ticket #10602: If a Matroska track > has a palette, said palette will be attached as side-data to the > first packet of said track and most likely, this is one read during > avformat_find_stream_info(). Yet if this packet is discarded because > of a seek performed immediately after avformat_find_stream_info(), > the information about the global palette will never reach the user. >=20 > Signed-off-by: Andreas Rheinhardt > --- > Ticket #10602 can unfortunately not be fixed in this way, > because avi allows to update the palette mid-stream, > so that the palette contained in extradata must not be > exported via global side data due to the semantics of the latter. >=20 > libavformat/matroskadec.c | 39 ++++++++++++--------------------------- > 1 file changed, 12 insertions(+), 27 deletions(-) breaks: aletrek.mkv probably here: https://trac.ffmpeg.org/attachment/ticket/5071/aletrek.mkv thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The worst form of inequality is to try to make unequal things equal. -- Aristotle --fbglzKaagM3twbm3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZSLanAAKCRBhHseHBAsP q63ZAJ49vGNx6TDLo87yxb8HKvg3BVmIZQCggBfJTHPSfVzWwZSRiARTW7JZEus= =v1lw -----END PGP SIGNATURE----- --fbglzKaagM3twbm3-- --===============2838629386039922004== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2838629386039922004==--