From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EC59B4740E for ; Sat, 7 Oct 2023 16:44:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8DB4268CAD8; Sat, 7 Oct 2023 19:44:46 +0300 (EEST) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A39E068C96D for ; Sat, 7 Oct 2023 19:44:39 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id BB3D5FF80E for ; Sat, 7 Oct 2023 16:44:38 +0000 (UTC) Date: Sat, 7 Oct 2023 18:44:37 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20231007164437.GQ3543730@pb2> References: MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 10/12] avcodec/rv10: Replace switch by LUT X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5499940649628812478==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5499940649628812478== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yrPCcEe+QcWQl/Hn" Content-Disposition: inline --yrPCcEe+QcWQl/Hn Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 06, 2023 at 04:03:40AM +0200, Andreas Rheinhardt wrote: > Vittorio Giovara: > > On Tue, Oct 3, 2023 at 12:03=E2=80=AFPM Andreas Rheinhardt < > > andreas.rheinhardt@outlook.com> wrote: > >=20 > >> Signed-off-by: Andreas Rheinhardt > >> --- > >> libavcodec/rv10.c | 21 +++++---------------- > >> 1 file changed, 5 insertions(+), 16 deletions(-) > >> > >> diff --git a/libavcodec/rv10.c b/libavcodec/rv10.c > >> index 3f9d5ff242..216328ffe7 100644 > >> --- a/libavcodec/rv10.c > >> +++ b/libavcodec/rv10.c > >> @@ -158,25 +158,14 @@ static int rv10_decode_picture_header(MpegEncCon= text > >> *s) > >> > >> static int rv20_decode_picture_header(RVDecContext *rv, int whole_siz= e) > >> { > >> + static const enum AVPictureType pict_types[] =3D > >> + { AV_PICTURE_TYPE_I, AV_PICTURE_TYPE_I /* hmm ... */, > >> > >=20 > > Any chance we could replace this comment with something more detailed (= or > > remove it if not needed)? >=20 > The comment has been added when the mapping for 1 was added in > 248a1aa54c0 (which made the default case dead code). I simply preserved > it, Michael probably added it to show that he was not completely sure. I > don't know whether there are different semantics for the two values. > I do not object to the removal of this comment. Its a bit odd when 2 values mean the same thing in a reverse engeneered format. One kind of thinks, that there is likely some difference that we just dont know about. maybe teh comment could elaborate in this direction and or someone could recheck if this is still the current best knowledge ... thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Let us carefully observe those good qualities wherein our enemies excel us and endeavor to excel them, by avoiding what is faulty, and imitating what is excellent in them. -- Plutarch --yrPCcEe+QcWQl/Hn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZSGK8QAKCRBhHseHBAsP q2KIAJ4vCM5pqdF1L+AxzGuRbnMrkCvo9wCfcXwbrO7HNdcHDyprz0V2CNNAVS4= =ch5O -----END PGP SIGNATURE----- --yrPCcEe+QcWQl/Hn-- --===============5499940649628812478== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5499940649628812478==--