From: James Almer <jamrial@gmail.com> To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH 7/7] fftools/ffplay: support applying container level cropping Date: Sat, 7 Oct 2023 13:25:03 -0300 Message-ID: <20231007162503.1057-8-jamrial@gmail.com> (raw) In-Reply-To: <20231007162503.1057-1-jamrial@gmail.com> Signed-off-by: James Almer <jamrial@gmail.com> --- fftools/ffplay.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index d8c69e10bc..5c213bf0d8 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -36,6 +36,7 @@ #include "libavutil/eval.h" #include "libavutil/mathematics.h" #include "libavutil/pixdesc.h" +#include "libavutil/intreadwrite.h" #include "libavutil/imgutils.h" #include "libavutil/dict.h" #include "libavutil/fifo.h" @@ -348,6 +349,7 @@ static const char **vfilters_list = NULL; static int nb_vfilters = 0; static char *afilters = NULL; static int autorotate = 1; +static int apply_cropping = 1; static int find_stream_info = 1; static int filter_nbthreads = 0; @@ -1910,6 +1912,28 @@ static int configure_video_filters(AVFilterGraph *graph, VideoState *is, const c last_filter = filt_ctx; \ } while (0) + if (apply_cropping) { + AVPacketSideData *sd = av_packet_side_data_get(is->video_st->codecpar->coded_side_data, + is->video_st->codecpar->nb_coded_side_data, + AV_PKT_DATA_FRAME_CROPPING); + + if (sd->data && sd->size == sizeof(uint32_t) * 4) { + char crop_buf[64]; + int top = AV_RL32(sd->data + 0); + int bottom = AV_RL32(sd->data + 4); + int left = AV_RL32(sd->data + 8); + int right = AV_RL32(sd->data + 12); + + if (top < 0 || bottom < 0 || left < 0 || right < 0) { + ret = AVERROR(EINVAL); + goto fail; + } + + snprintf(crop_buf, sizeof(crop_buf), "w=iw-%d-%d:h=ih-%d-%d", left, right, top, bottom); + INSERT_FILT("crop", crop_buf); + } + } + if (autorotate) { double theta = 0.0; int32_t *displaymatrix = NULL; @@ -2610,6 +2634,7 @@ static int stream_component_open(VideoState *is, int stream_index) av_dict_set(&opts, "threads", "auto", 0); if (stream_lowres) av_dict_set_int(&opts, "lowres", stream_lowres, 0); + av_dict_set_int(&opts, "apply_cropping", apply_cropping, 0); av_dict_set(&opts, "flags", "+copy_opaque", AV_DICT_MULTIKEY); @@ -3608,6 +3633,7 @@ static const OptionDef options[] = { { "scodec", HAS_ARG | OPT_STRING | OPT_EXPERT, { &subtitle_codec_name }, "force subtitle decoder", "decoder_name" }, { "vcodec", HAS_ARG | OPT_STRING | OPT_EXPERT, { &video_codec_name }, "force video decoder", "decoder_name" }, { "autorotate", OPT_BOOL, { &autorotate }, "automatically rotate video", "" }, + { "apply_cropping", OPT_BOOL, { &apply_cropping }, "apply frame cropping", "" }, { "find_stream_info", OPT_BOOL | OPT_INPUT | OPT_EXPERT, { &find_stream_info }, "read and decode the streams to fill missing information with heuristics" }, { "filter_threads", HAS_ARG | OPT_INT | OPT_EXPERT, { &filter_nbthreads }, "number of filter threads per graph" }, -- 2.42.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-10-07 16:26 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-10-07 16:24 [FFmpeg-devel] [PATCH 0/7] Container level frame cropping parameters James Almer 2023-10-07 16:24 ` [FFmpeg-devel] [PATCH 1/7] avcodec/packet: add a decoded frame cropping side data type James Almer 2023-10-10 11:30 ` Andreas Rheinhardt 2023-10-07 16:24 ` [FFmpeg-devel] [PATCH 2/7] avformat/dump: print Frame Cropping side data info James Almer 2023-10-10 11:03 ` Anton Khirnov 2023-10-07 16:24 ` [FFmpeg-devel] [PATCH 3/7] avformat/matroskadec: export cropping values James Almer 2023-10-07 16:25 ` [FFmpeg-devel] [PATCH 4/7] avformat/avformat: add a flag to signal muxers that support storing " James Almer 2023-10-10 11:09 ` Anton Khirnov 2023-10-10 11:13 ` James Almer 2023-10-10 11:16 ` Anton Khirnov 2023-10-10 11:21 ` James Almer 2023-10-10 11:28 ` Anton Khirnov 2023-10-07 16:25 ` [FFmpeg-devel] [PATCH 5/7] avformat/matroskaenc: support writing " James Almer 2023-10-07 16:25 ` [FFmpeg-devel] [PATCH 6/7] fftools/ffmpeg: support applying container level cropping James Almer 2023-10-10 11:13 ` Anton Khirnov 2023-10-07 16:25 ` James Almer [this message] 2024-01-17 18:39 ` [FFmpeg-devel] [PATCH 7/7] fftools/ffplay: " Dmitrii Ovchinnikov 2023-10-10 11:17 ` [FFmpeg-devel] [PATCH 0/7] Container level frame cropping parameters Anton Khirnov 2023-10-10 11:44 ` James Almer 2023-10-10 11:54 ` Anton Khirnov 2023-10-10 11:58 ` James Almer 2023-10-10 12:12 ` Anton Khirnov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20231007162503.1057-8-jamrial@gmail.com \ --to=jamrial@gmail.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git