From: James Almer <jamrial@gmail.com> To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH 4/7] avformat/avformat: add a flag to signal muxers that support storing cropping values Date: Sat, 7 Oct 2023 13:25:00 -0300 Message-ID: <20231007162503.1057-5-jamrial@gmail.com> (raw) In-Reply-To: <20231007162503.1057-1-jamrial@gmail.com> Signed-off-by: James Almer <jamrial@gmail.com> --- libavformat/avformat.h | 1 + libavformat/mux.c | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 9e7eca007e..c099ca8a01 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@ -500,6 +500,7 @@ typedef struct AVProbeData { The user or muxer can override this through AVFormatContext.avoid_negative_ts */ +#define AVFMT_CROPPING 0x80000 /**< Format supports storing cropping values */ #define AVFMT_SEEK_TO_PTS 0x4000000 /**< Seeking is based on PTS */ diff --git a/libavformat/mux.c b/libavformat/mux.c index c7877c5d98..c5e8a4ca74 100644 --- a/libavformat/mux.c +++ b/libavformat/mux.c @@ -188,6 +188,7 @@ static int init_muxer(AVFormatContext *s, AVDictionary **options) AVDictionary *tmp = NULL; const FFOutputFormat *of = ffofmt(s->oformat); AVDictionaryEntry *e; + int warned_crop = 0; int ret = 0; if (options) @@ -276,6 +277,13 @@ FF_ENABLE_DEPRECATION_WARNINGS goto fail; } } + if (!warned_crop && !(s->oformat->flags & AVFMT_CROPPING) && + av_packet_side_data_get(st->codecpar->coded_side_data, + st->codecpar->nb_coded_side_data, + AV_PKT_DATA_FRAME_CROPPING)) { + av_log(s, AV_LOG_WARNING, "Muxer does not support storing cropping values\n"); + warned_crop = 1; + } break; } -- 2.42.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-10-07 16:25 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-10-07 16:24 [FFmpeg-devel] [PATCH 0/7] Container level frame cropping parameters James Almer 2023-10-07 16:24 ` [FFmpeg-devel] [PATCH 1/7] avcodec/packet: add a decoded frame cropping side data type James Almer 2023-10-10 11:30 ` Andreas Rheinhardt 2023-10-07 16:24 ` [FFmpeg-devel] [PATCH 2/7] avformat/dump: print Frame Cropping side data info James Almer 2023-10-10 11:03 ` Anton Khirnov 2023-10-07 16:24 ` [FFmpeg-devel] [PATCH 3/7] avformat/matroskadec: export cropping values James Almer 2023-10-07 16:25 ` James Almer [this message] 2023-10-10 11:09 ` [FFmpeg-devel] [PATCH 4/7] avformat/avformat: add a flag to signal muxers that support storing " Anton Khirnov 2023-10-10 11:13 ` James Almer 2023-10-10 11:16 ` Anton Khirnov 2023-10-10 11:21 ` James Almer 2023-10-10 11:28 ` Anton Khirnov 2023-10-07 16:25 ` [FFmpeg-devel] [PATCH 5/7] avformat/matroskaenc: support writing " James Almer 2023-10-07 16:25 ` [FFmpeg-devel] [PATCH 6/7] fftools/ffmpeg: support applying container level cropping James Almer 2023-10-10 11:13 ` Anton Khirnov 2023-10-07 16:25 ` [FFmpeg-devel] [PATCH 7/7] fftools/ffplay: " James Almer 2024-01-17 18:39 ` Dmitrii Ovchinnikov 2023-10-10 11:17 ` [FFmpeg-devel] [PATCH 0/7] Container level frame cropping parameters Anton Khirnov 2023-10-10 11:44 ` James Almer 2023-10-10 11:54 ` Anton Khirnov 2023-10-10 11:58 ` James Almer 2023-10-10 12:12 ` Anton Khirnov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20231007162503.1057-5-jamrial@gmail.com \ --to=jamrial@gmail.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git