From: Anton Khirnov <anton@khirnov.net>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH 03/12] fftools/ffmpeg_enc: simplify adjust_frame_pts_to_encoder_tb() signature
Date: Tue, 3 Oct 2023 17:35:17 +0200
Message-ID: <20231003153526.19228-3-anton@khirnov.net> (raw)
In-Reply-To: <20231003153526.19228-1-anton@khirnov.net>
It does not need an OutputFile and an OutputStream, only the target
timebase and the timestamp offset.
---
fftools/ffmpeg_enc.c | 25 ++++++++++---------------
1 file changed, 10 insertions(+), 15 deletions(-)
diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c
index 0c51d9f0c6..b928bf208c 100644
--- a/fftools/ffmpeg_enc.c
+++ b/fftools/ffmpeg_enc.c
@@ -917,16 +917,12 @@ static int do_audio_out(OutputFile *of, OutputStream *ost,
return (ret < 0 && ret != AVERROR_EOF) ? ret : 0;
}
-static double adjust_frame_pts_to_encoder_tb(OutputFile *of, OutputStream *ost,
- AVFrame *frame)
+static double adjust_frame_pts_to_encoder_tb(AVFrame *frame, AVRational tb_dst,
+ int64_t start_time)
{
double float_pts = AV_NOPTS_VALUE; // this is identical to frame.pts but with higher precision
- const int64_t start_time = (of->start_time == AV_NOPTS_VALUE) ?
- 0 : of->start_time;
- AVCodecContext *const enc = ost->enc_ctx;
-
- AVRational tb = enc->time_base;
+ AVRational tb = tb_dst;
AVRational filter_tb = frame->time_base;
const int extra_bits = av_clip(29 - av_log2(tb.den), 0, 16);
@@ -943,19 +939,17 @@ static double adjust_frame_pts_to_encoder_tb(OutputFile *of, OutputStream *ost,
if (float_pts != llrint(float_pts))
float_pts += FFSIGN(float_pts) * 1.0 / (1<<17);
- frame->pts = av_rescale_q(frame->pts, filter_tb, enc->time_base) -
- av_rescale_q(start_time, AV_TIME_BASE_Q, enc->time_base);
- frame->time_base = enc->time_base;
+ frame->pts = av_rescale_q(frame->pts, filter_tb, tb_dst) -
+ av_rescale_q(start_time, AV_TIME_BASE_Q, tb_dst);
+ frame->time_base = tb_dst;
early_exit:
if (debug_ts) {
av_log(NULL, AV_LOG_INFO, "filter -> pts:%s pts_time:%s exact:%f time_base:%d/%d\n",
frame ? av_ts2str(frame->pts) : "NULL",
- (enc && frame) ? av_ts2timestr(frame->pts, &enc->time_base) : "NULL",
- float_pts,
- enc ? enc->time_base.num : -1,
- enc ? enc->time_base.den : -1);
+ av_ts2timestr(frame->pts, &tb_dst),
+ float_pts, tb_dst.num, tb_dst.den);
}
return float_pts;
@@ -981,7 +975,8 @@ static void video_sync_process(OutputFile *of, OutputStream *ost, AVFrame *frame
duration = frame->duration * av_q2d(frame->time_base) / av_q2d(enc->time_base);
- sync_ipts = adjust_frame_pts_to_encoder_tb(of, ost, frame);
+ sync_ipts = adjust_frame_pts_to_encoder_tb(frame, enc->time_base,
+ of->start_time == AV_NOPTS_VALUE ? 0 : of->start_time);
/* delta0 is the "drift" between the input frame and
* where it would fall in the output. */
delta0 = sync_ipts - e->next_pts;
--
2.40.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-10-03 15:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 15:35 [FFmpeg-devel] [PATCH 01/12] fftools/ffmpeg_enc: move handling video frame duration to video_sync_process() Anton Khirnov
2023-10-03 15:35 ` [FFmpeg-devel] [PATCH 02/12] fftools/ffmpeg_enc: move remaining vsync-related code " Anton Khirnov
2023-10-03 15:35 ` Anton Khirnov [this message]
2023-10-03 15:35 ` [FFmpeg-devel] [PATCH 04/12] ffools/ffmpeg_filter: stop trying to handle an unreachable state Anton Khirnov
2023-10-03 15:35 ` [FFmpeg-devel] [PATCH 05/12] tests/fate/ffmpeg: add tests for -force_key_frames source Anton Khirnov
2023-10-03 15:35 ` [FFmpeg-devel] [PATCH 06/12] fftools/ffmpeg_enc: unbreak -force_key_frames source_no_drop Anton Khirnov
2023-10-03 15:35 ` [FFmpeg-devel] [PATCH 07/12] fftools/ffmpeg_enc: merge -force_key_frames source/source_no_drop Anton Khirnov
2023-10-03 15:35 ` [FFmpeg-devel] [PATCH 08/12] fftools/ffmpeg: stop accessing OutputStream.last_dropped in print_report() Anton Khirnov
2023-10-03 15:35 ` [FFmpeg-devel] [PATCH 09/12] fftools/ffmpeg_enc: move framerate conversion state into a separate struct Anton Khirnov
2023-10-03 15:35 ` [FFmpeg-devel] [PATCH 10/12] fftools/ffmpeg_enc: move fps conversion code to ffmpeg_filter Anton Khirnov
2023-10-03 15:35 ` [FFmpeg-devel] [PATCH 11/12] fftools/ffmpeg_filter: fail on filtering errors Anton Khirnov
2023-10-03 15:35 ` [FFmpeg-devel] [PATCH 12/12] fftools/ffmpeg_enc: constify the frame passed to enc_open() Anton Khirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231003153526.19228-3-anton@khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git