From: John Mather via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: John Mather <johnmather@sidefx.com>
Subject: [FFmpeg-devel] [PATCH v3] avcodec/libkvazaar: Respect codec context color settings.
Date: Mon, 2 Oct 2023 13:20:49 -0400
Message-ID: <20231002172049.69615-1-johnmather@sidefx.com> (raw)
This patch makes the libkvazaar encoder respect color settings that are
present on the codec context, including color range, primaries, transfer
function and colorspace.
---
This addresses the issues raised in v2.
* The unspecified conditions have been removed as they were
unnecessary.
* Added the ability to specify the chroma sample location. The
unspecified check is required here as without it, if
avctx->chroma_sample_location was AVCHROMA_LOC_UNSPECIFIED,
cfg->vui.chroma_loc would receive -1, which is outside of the
expected range.
libavcodec/libkvazaar.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/libavcodec/libkvazaar.c b/libavcodec/libkvazaar.c
index 2ef34dd82e..4855d5649d 100644
--- a/libavcodec/libkvazaar.c
+++ b/libavcodec/libkvazaar.c
@@ -101,6 +101,13 @@ FF_ENABLE_DEPRECATION_WARNINGS
cfg->rc_algorithm = KVZ_LAMBDA;
}
+ cfg->vui.fullrange = avctx->color_range == AVCOL_RANGE_JPEG;
+ cfg->vui.colorprim = avctx->color_primaries;
+ cfg->vui.transfer = avctx->color_trc;
+ cfg->vui.colormatrix = avctx->colorspace;
+ if (avctx->chroma_sample_location != AVCHROMA_LOC_UNSPECIFIED)
+ cfg->vui.chroma_loc = avctx->chroma_sample_location - 1;
+
if (ctx->kvz_params) {
AVDictionary *dict = NULL;
if (!av_dict_parse_string(&dict, ctx->kvz_params, "=", ",", 0)) {
--
2.39.3
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2023-10-02 17:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 17:20 John Mather via ffmpeg-devel [this message]
2023-10-11 18:59 ` Jan Ekström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231002172049.69615-1-johnmather@sidefx.com \
--to=ffmpeg-devel@ffmpeg.org \
--cc=johnmather@sidefx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git